components/password_manager/core/browser/password_form_manager_unittest.cc - Issue 684513002: Standardize usage of virtual/override/final specifiers.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/password_manager/core/browser/password_form_manager_unittest.cc

Issue 684513002: Standardize usage of virtual/override/final specifiers. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/password_manager/core/browser/password_autofill_manager_unittest.cc ('k') | components/password_manager/core/browser/password_generation_manager_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/password_manager/core/browser/password_form_manager_unittest.cc

diff --git a/components/password_manager/core/browser/password_form_manager_unittest.cc b/components/password_manager/core/browser/password_form_manager_unittest.cc

index 92194294c01f4fed556e9acc243430e846341027..c38ed9aad5b183094dcd6875c38404fc82e57dcc 100644

--- a/components/password_manager/core/browser/password_form_manager_unittest.cc

+++ b/components/password_manager/core/browser/password_form_manager_unittest.cc

@@ -153,7 +153,7 @@ class PasswordFormManagerTest : public testing::Test {

// SimulateMatchingPhase.

enum ResultOfSimulatedMatching { RESULT_MATCH_FOUND, RESULT_NO_MATCH };

- virtual void SetUp() {

+ void SetUp() override {

observed_form_.origin = GURL("http://accounts.google.com/a/LoginAuth");

observed_form_.action = GURL("http://accounts.google.com/a/Login");

observed_form_.username_element = ASCIIToUTF16("Email");

@@ -174,7 +174,7 @@ class PasswordFormManagerTest : public testing::Test {

client_.reset(new TestPasswordManagerClient(mock_store_.get()));

}

- virtual void TearDown() {

+ void TearDown() override {

if (mock_store_.get())

mock_store_->Shutdown();

}