components/feedback/feedback_common_unittest.cc - Issue 684513002: Standardize usage of virtual/override/final specifiers.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/feedback/feedback_common_unittest.cc

Issue 684513002: Standardize usage of virtual/override/final specifiers. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/error_page/renderer/net_error_helper_core_unittest.cc ('k') | components/feedback/feedback_uploader_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/feedback/feedback_common_unittest.cc

diff --git a/components/feedback/feedback_common_unittest.cc b/components/feedback/feedback_common_unittest.cc

index a88a86611cde865f7f9ef4a2bba6153025c421dc..d3fb9502210c7de0d591c84275b96038a58a6793 100644

--- a/components/feedback/feedback_common_unittest.cc

+++ b/components/feedback/feedback_common_unittest.cc

@@ -28,7 +28,7 @@ class FeedbackCommonTest : public testing::Test {

feedback = scoped_refptr<FeedbackCommon>(new FeedbackCommon());

}

- virtual ~FeedbackCommonTest() {}

+ ~FeedbackCommonTest() override {}

scoped_refptr<FeedbackCommon> feedback;

userfeedback::ExtensionSubmit report;