Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(173)

Unified Diff: components/error_page/renderer/net_error_helper_core_unittest.cc

Issue 684513002: Standardize usage of virtual/override/final specifiers. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/error_page/renderer/net_error_helper_core_unittest.cc
diff --git a/components/error_page/renderer/net_error_helper_core_unittest.cc b/components/error_page/renderer/net_error_helper_core_unittest.cc
index 240299980b53eeb99da5038873d280fdd2f4ac9d..0aed02599222ce9289c6edf9fbada062733f130e 100644
--- a/components/error_page/renderer/net_error_helper_core_unittest.cc
+++ b/components/error_page/renderer/net_error_helper_core_unittest.cc
@@ -159,14 +159,12 @@ class NetErrorHelperCoreTest : public testing::Test,
SetUpCore(false, false, true);
}
- virtual ~NetErrorHelperCoreTest() {
+ ~NetErrorHelperCoreTest() override {
// No test finishes while an error page is being fetched.
EXPECT_FALSE(is_url_being_fetched());
}
- virtual void SetUp() override {
- base::StatisticsRecorder::Initialize();
- }
+ void SetUp() override { base::StatisticsRecorder::Initialize(); }
void SetUpCore(bool auto_reload_enabled,
bool auto_reload_visible_only,
@@ -1939,7 +1937,7 @@ TEST_F(NetErrorHelperCoreTest, AutoReloadDisabled) {
class NetErrorHelperCoreAutoReloadTest : public NetErrorHelperCoreTest {
public:
- virtual void SetUp() {
+ void SetUp() override {
NetErrorHelperCoreTest::SetUp();
SetUpCore(true, false, true);
}
@@ -2243,9 +2241,7 @@ TEST_F(NetErrorHelperCoreAutoReloadTest, ShownWhileNotReloading) {
class NetErrorHelperCoreHistogramTest
: public NetErrorHelperCoreAutoReloadTest {
public:
- virtual void SetUp() override {
- NetErrorHelperCoreAutoReloadTest::SetUp();
- }
+ void SetUp() override { NetErrorHelperCoreAutoReloadTest::SetUp(); }
static const char kCountAtStop[];
static const char kErrorAtStop[];
« no previous file with comments | « components/enhanced_bookmarks/enhanced_bookmark_utils_unittest.cc ('k') | components/feedback/feedback_common_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698