components/enhanced_bookmarks/enhanced_bookmark_model_unittest.cc - Issue 684513002: Standardize usage of virtual/override/final specifiers.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/enhanced_bookmarks/enhanced_bookmark_model_unittest.cc

Issue 684513002: Standardize usage of virtual/override/final specifiers. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/dom_distiller/standalone/content_extractor.cc ('k') | components/enhanced_bookmarks/enhanced_bookmark_utils_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/enhanced_bookmarks/enhanced_bookmark_model_unittest.cc

diff --git a/components/enhanced_bookmarks/enhanced_bookmark_model_unittest.cc b/components/enhanced_bookmarks/enhanced_bookmark_model_unittest.cc

index 4d9f2e7a2813e49e370c8d17cf7ffcb965a6ed65..f1b8994e0b5c19c8389c9180166976a484b662fa 100644

--- a/components/enhanced_bookmarks/enhanced_bookmark_model_unittest.cc

+++ b/components/enhanced_bookmarks/enhanced_bookmark_model_unittest.cc

@@ -40,9 +40,9 @@ class EnhancedBookmarkModelTest

last_added_(NULL),

last_removed_(NULL),

last_remote_id_node_(NULL) {}

- virtual ~EnhancedBookmarkModelTest() {}

+ ~EnhancedBookmarkModelTest() override {}

- virtual void SetUp() override {

+ void SetUp() override {

message_loop_.reset(new base::MessageLoop(base::MessageLoop::TYPE_DEFAULT));

bookmark_client_.reset(new bookmarks::TestBookmarkClient());

bookmark_model_.reset(bookmark_client_->CreateModel().release());

@@ -50,7 +50,7 @@ class EnhancedBookmarkModelTest

model_->AddObserver(this);

}

- virtual void TearDown() override {

+ void TearDown() override {

if (model_)

model_->Shutdown();

model_.reset();