Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(242)

Unified Diff: components/dom_distiller/standalone/content_extractor.cc

Issue 684513002: Standardize usage of virtual/override/final specifiers. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/dom_distiller/standalone/content_extractor.cc
diff --git a/components/dom_distiller/standalone/content_extractor.cc b/components/dom_distiller/standalone/content_extractor.cc
index b6a5a4e98995f031a480efbf158ac52d48a2b8c7..8f960b2d03528dda4badd42339f25aa6b22dbd75 100644
--- a/components/dom_distiller/standalone/content_extractor.cc
+++ b/components/dom_distiller/standalone/content_extractor.cc
@@ -209,11 +209,9 @@ class ContentExtractionRequest : public ViewRequestDelegate {
private:
ContentExtractionRequest(const GURL& url) : url_(url) {}
- virtual void OnArticleUpdated(ArticleDistillationUpdate article_update)
- override {}
+ void OnArticleUpdated(ArticleDistillationUpdate article_update) override {}
- virtual void OnArticleReady(const DistilledArticleProto* article_proto)
- override {
+ void OnArticleReady(const DistilledArticleProto* article_proto) override {
article_proto_ = article_proto;
CHECK(article_proto->pages_size()) << "Failed extracting " << url_;
base::MessageLoop::current()->PostTask(
@@ -239,7 +237,7 @@ class ContentExtractor : public ContentBrowserTest {
// Change behavior of the default host resolver to avoid DNS lookup errors, so
// we can make network calls.
- virtual void SetUpOnMainThread() override {
+ void SetUpOnMainThread() override {
if (!CommandLine::ForCurrentProcess()->HasSwitch(kDisableDnsSwitch)) {
EnableDNSLookupForThisTest();
}
@@ -247,9 +245,7 @@ class ContentExtractor : public ContentBrowserTest {
AddComponentsResources();
}
- virtual void TearDownOnMainThread() override {
- DisableDNSLookupForThisTest();
- }
+ void TearDownOnMainThread() override { DisableDNSLookupForThisTest(); }
protected:
// Creates the DomDistillerService and creates and starts the extraction
« no previous file with comments | « components/dom_distiller/core/viewer_unittest.cc ('k') | components/enhanced_bookmarks/enhanced_bookmark_model_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698