components/crash/browser/crash_handler_host_linux.h - Issue 684513002: Standardize usage of virtual/override/final specifiers.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/crash/browser/crash_handler_host_linux.h

Issue 684513002: Standardize usage of virtual/override/final specifiers. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/crash/app/breakpad_linux.cc ('k') | components/data_reduction_proxy/core/browser/data_reduction_proxy_config_service_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/crash/browser/crash_handler_host_linux.h

diff --git a/components/crash/browser/crash_handler_host_linux.h b/components/crash/browser/crash_handler_host_linux.h

index f655360fd0effeaf68fb9fff6133b3fce89b3643..876a0a5eb13e37d4548f8574a29113c5bac8181d 100644

--- a/components/crash/browser/crash_handler_host_linux.h

+++ b/components/crash/browser/crash_handler_host_linux.h

@@ -36,7 +36,7 @@ class CrashHandlerHostLinux : public base::MessageLoopForIO::Watcher,

CrashHandlerHostLinux(const std::string& process_type,

const base::FilePath& dumps_path,

bool upload);

- virtual ~CrashHandlerHostLinux();

+ ~CrashHandlerHostLinux() override;

// Starts the uploader thread. Must be called immediately after creating the

// class.

@@ -49,11 +49,11 @@ class CrashHandlerHostLinux : public base::MessageLoopForIO::Watcher,

}

// MessagePumbLibevent::Watcher impl:

- virtual void OnFileCanWriteWithoutBlocking(int fd) override;

- virtual void OnFileCanReadWithoutBlocking(int fd) override;

+ void OnFileCanWriteWithoutBlocking(int fd) override;

+ void OnFileCanReadWithoutBlocking(int fd) override;

// MessageLoop::DestructionObserver impl:

- virtual void WillDestroyCurrentMessageLoop() override;

+ void WillDestroyCurrentMessageLoop() override;

// Whether we are shutting down or not.

bool IsShuttingDown() const;