Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(172)

Side by Side Diff: components/crash/browser/crash_handler_host_linux.h

Issue 684513002: Standardize usage of virtual/override/final specifiers. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef COMPONENTS_CRASH_BROWSER_CRASH_HANDLER_HOST_LINUX_H_ 5 #ifndef COMPONENTS_CRASH_BROWSER_CRASH_HANDLER_HOST_LINUX_H_
6 #define COMPONENTS_CRASH_BROWSER_CRASH_HANDLER_HOST_LINUX_H_ 6 #define COMPONENTS_CRASH_BROWSER_CRASH_HANDLER_HOST_LINUX_H_
7 7
8 #include <sys/types.h> 8 #include <sys/types.h>
9 9
10 #include <string> 10 #include <string>
(...skipping 18 matching lines...) Expand all
29 // 29 //
30 // Processes signal that they need to be dumped by sending a datagram over a 30 // Processes signal that they need to be dumped by sending a datagram over a
31 // UNIX domain socket. All processes of the same type share the client end of 31 // UNIX domain socket. All processes of the same type share the client end of
32 // this socket which is installed in their descriptor table before exec. 32 // this socket which is installed in their descriptor table before exec.
33 class CrashHandlerHostLinux : public base::MessageLoopForIO::Watcher, 33 class CrashHandlerHostLinux : public base::MessageLoopForIO::Watcher,
34 public base::MessageLoop::DestructionObserver { 34 public base::MessageLoop::DestructionObserver {
35 public: 35 public:
36 CrashHandlerHostLinux(const std::string& process_type, 36 CrashHandlerHostLinux(const std::string& process_type,
37 const base::FilePath& dumps_path, 37 const base::FilePath& dumps_path,
38 bool upload); 38 bool upload);
39 virtual ~CrashHandlerHostLinux(); 39 ~CrashHandlerHostLinux() override;
40 40
41 // Starts the uploader thread. Must be called immediately after creating the 41 // Starts the uploader thread. Must be called immediately after creating the
42 // class. 42 // class.
43 void StartUploaderThread(); 43 void StartUploaderThread();
44 44
45 // Get the file descriptor which processes should be given in order to signal 45 // Get the file descriptor which processes should be given in order to signal
46 // crashes to the browser. 46 // crashes to the browser.
47 int GetDeathSignalSocket() const { 47 int GetDeathSignalSocket() const {
48 return process_socket_; 48 return process_socket_;
49 } 49 }
50 50
51 // MessagePumbLibevent::Watcher impl: 51 // MessagePumbLibevent::Watcher impl:
52 virtual void OnFileCanWriteWithoutBlocking(int fd) override; 52 void OnFileCanWriteWithoutBlocking(int fd) override;
53 virtual void OnFileCanReadWithoutBlocking(int fd) override; 53 void OnFileCanReadWithoutBlocking(int fd) override;
54 54
55 // MessageLoop::DestructionObserver impl: 55 // MessageLoop::DestructionObserver impl:
56 virtual void WillDestroyCurrentMessageLoop() override; 56 void WillDestroyCurrentMessageLoop() override;
57 57
58 // Whether we are shutting down or not. 58 // Whether we are shutting down or not.
59 bool IsShuttingDown() const; 59 bool IsShuttingDown() const;
60 60
61 private: 61 private:
62 void Init(); 62 void Init();
63 63
64 // Do work in a sequenced worker pool for OnFileCanReadWithoutBlocking(). 64 // Do work in a sequenced worker pool for OnFileCanReadWithoutBlocking().
65 void WriteDumpFile(scoped_ptr<BreakpadInfo> info, 65 void WriteDumpFile(scoped_ptr<BreakpadInfo> info,
66 scoped_ptr<char[]> crash_context, 66 scoped_ptr<char[]> crash_context,
(...skipping 17 matching lines...) Expand all
84 // Unique sequence token so that writing crash dump won't be blocked 84 // Unique sequence token so that writing crash dump won't be blocked
85 // by other tasks. 85 // by other tasks.
86 base::SequencedWorkerPool::SequenceToken worker_pool_token_; 86 base::SequencedWorkerPool::SequenceToken worker_pool_token_;
87 87
88 DISALLOW_COPY_AND_ASSIGN(CrashHandlerHostLinux); 88 DISALLOW_COPY_AND_ASSIGN(CrashHandlerHostLinux);
89 }; 89 };
90 90
91 } // namespace breakpad 91 } // namespace breakpad
92 92
93 #endif // COMPONENTS_CRASH_BROWSER_CRASH_HANDLER_HOST_LINUX_H_ 93 #endif // COMPONENTS_CRASH_BROWSER_CRASH_HANDLER_HOST_LINUX_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698