Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(77)

Unified Diff: third_party/android_crazy_linker/src/src/crazy_linker_library_list.h

Issue 684453003: Add UMA for testing whether the Chromium library was page aligned in the APK file. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Update for review feedback Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/android_crazy_linker/src/src/crazy_linker_library_list.h
diff --git a/third_party/android_crazy_linker/src/src/crazy_linker_library_list.h b/third_party/android_crazy_linker/src/src/crazy_linker_library_list.h
index 9759a77a6e50b9b9bfd3dfa8e2e91bcc339e9235..6539b8056a8af9b8c4868d343da67fcc921f2485 100644
--- a/third_party/android_crazy_linker/src/src/crazy_linker_library_list.h
+++ b/third_party/android_crazy_linker/src/src/crazy_linker_library_list.h
@@ -71,6 +71,14 @@ class LibraryList {
SearchPathList* search_path_list,
Error* error);
+ // Find the location of a library in the zip file. If the name of the library
+ // is too long, an error occurs during the search or the library is not
+ // page aligned in the zip file, CRAZY_OFFSET_FAILED is returned. Otherwise,
+ // the offset of the library in the zip file is returned.
+ static int FindAlignedLibraryInZipFile(const char* zip_file_path,
+ const char* lib_name,
+ Error* error);
+
// Try to load a library from its location in the zip file.
// On failure, returns NULL and sets the |error| message.
LibraryView* LoadLibraryInZipFile(const char* zip_file_path,

Powered by Google App Engine
This is Rietveld 408576698