third_party/android_crazy_linker/src/src/crazy_linker_api.cpp - Issue 684453003: Add UMA for testing whether the Chromium library was page aligned in the APK file.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/android_crazy_linker/src/src/crazy_linker_api.cpp

Issue 684453003: Add UMA for testing whether the Chromium library was page aligned in the APK file. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Update for review feedback Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/android_crazy_linker/src/include/crazy_linker.h ('k') | third_party/android_crazy_linker/src/src/crazy_linker_library_list.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/android_crazy_linker/src/src/crazy_linker_api.cpp

diff --git a/third_party/android_crazy_linker/src/src/crazy_linker_api.cpp b/third_party/android_crazy_linker/src/src/crazy_linker_api.cpp

index 10a64bfa63ee9b6290ba88a64ec33340d48073e4..80d29fdb0920724294d528364c6028ecf1ccd698 100644

--- a/third_party/android_crazy_linker/src/src/crazy_linker_api.cpp

+++ b/third_party/android_crazy_linker/src/src/crazy_linker_api.cpp

@@ -372,6 +372,17 @@ crazy_status_t crazy_library_find_from_address(void* address,

}

+crazy_status_t crazy_linker_check_library_aligned_in_zip_file(

+ const char* zipfile_name,

+ const char* lib_name) {

+ Error error;

+ if (crazy::LibraryList::FindAlignedLibraryInZipFile(

+ zipfile_name, lib_name, &error) == CRAZY_OFFSET_FAILED)

+ return CRAZY_STATUS_FAILURE;

+ return CRAZY_STATUS_SUCCESS;

void crazy_library_close(crazy_library_t* library) {

crazy_library_close_with_context(library, NULL);

}