Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Issue 684353002: Remove more stuff from Widget. (Closed)

Created:
6 years, 1 month ago by esprehn
Modified:
6 years, 1 month ago
Reviewers:
abarth-chromium, ojan
CC:
ojan, abarth-chromium, mojo-reviews_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Project:
mojo
Visibility:
Public.

Description

Remove more stuff from Widget. This removes even more APIs from widget. This also removes some methods that had been broken and made infinitely recursive on FrameView. R=abarth@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/fb557e51bd3243bd9aa82919e1a730caac2e154f

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -244 lines) Patch
M sky/engine/core/dom/Element.h View 1 chunk +0 lines, -5 lines 0 comments Download
M sky/engine/core/dom/Element.cpp View 2 chunks +0 lines, -32 lines 0 comments Download
M sky/engine/core/frame/FrameView.h View 1 chunk +5 lines, -9 lines 1 comment Download
M sky/engine/core/frame/FrameView.cpp View 1 chunk +0 lines, -8 lines 0 comments Download
M sky/engine/core/inspector/InspectorTraceEvents.cpp View 1 chunk +4 lines, -6 lines 0 comments Download
M sky/engine/platform/Widget.h View 1 chunk +4 lines, -22 lines 0 comments Download
M sky/engine/platform/Widget.cpp View 2 chunks +0 lines, -113 lines 0 comments Download
M sky/engine/platform/scroll/ScrollableArea.h View 1 chunk +6 lines, -18 lines 0 comments Download
M sky/engine/platform/scroll/Scrollbar.cpp View 4 chunks +6 lines, -6 lines 0 comments Download
M sky/engine/public/web/WebElement.h View 1 chunk +0 lines, -6 lines 0 comments Download
M sky/engine/web/WebElement.cpp View 1 chunk +0 lines, -5 lines 0 comments Download
M sky/engine/web/WebInputEventConversion.cpp View 7 chunks +8 lines, -14 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
abarth-chromium
lgtm
6 years, 1 month ago (2014-10-29 22:56:22 UTC) #1
esprehn
Committed patchset #1 (id:1) manually as fb557e51bd3243bd9aa82919e1a730caac2e154f (presubmit successful).
6 years, 1 month ago (2014-10-29 22:57:21 UTC) #2
ojan
6 years, 1 month ago (2014-10-30 00:41:04 UTC) #4
Message was sent while issue was closed.
https://codereview.chromium.org/684353002/diff/1/sky/engine/core/frame/FrameV...
File sky/engine/core/frame/FrameView.h (right):

https://codereview.chromium.org/684353002/diff/1/sky/engine/core/frame/FrameV...
sky/engine/core/frame/FrameView.h:206: IntPoint windowToContents(const IntPoint&
windowPoint) const { return windowPoint; }
Whoops.

Powered by Google App Engine
This is Rietveld 408576698