Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(692)

Unified Diff: sky/engine/platform/Widget.h

Issue 684353002: Remove more stuff from Widget. (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: sky/engine/platform/Widget.h
diff --git a/sky/engine/platform/Widget.h b/sky/engine/platform/Widget.h
index b5b33c9e9433a66a2908ff5f75ded4be4996328a..6d2605bca9378447cf91ca1267a54d690d8d7d94 100644
--- a/sky/engine/platform/Widget.h
+++ b/sky/engine/platform/Widget.h
@@ -70,32 +70,14 @@ public:
virtual bool isScrollbar() const { return false; }
virtual HostWindow* hostWindow() const { ASSERT_NOT_REACHED(); return 0; }
- void setParent(Widget* parent) { m_parent = parent; }
Widget* parent() const { return m_parent; }
Widget* root() const;
- IntRect convertToRootView(const IntRect&) const;
- IntRect convertFromRootView(const IntRect&) const;
-
- IntPoint convertToRootView(const IntPoint&) const;
- IntPoint convertFromRootView(const IntPoint&) const;
-
- // It is important for cross-platform code to realize that Mac has flipped coordinates. Therefore any code
- // that tries to convert the location of a rect using the point-based convertFromContainingWindow will end
- // up with an inaccurate rect. Always make sure to use the rect-based convertFromContainingWindow method
- // when converting window rects.
- IntRect convertToContainingWindow(const IntRect&) const;
- IntRect convertFromContainingWindow(const IntRect&) const;
-
- IntPoint convertToContainingWindow(const IntPoint&) const;
- IntPoint convertFromContainingWindow(const IntPoint&) const;
- FloatPoint convertFromContainingWindow(const FloatPoint&) const;
-
// Virtual methods to convert points to/from the containing ScrollView
- virtual IntRect convertToContainingView(const IntRect&) const;
- virtual IntRect convertFromContainingView(const IntRect&) const;
- virtual IntPoint convertToContainingView(const IntPoint&) const;
- virtual IntPoint convertFromContainingView(const IntPoint&) const;
+ virtual IntRect convertToContainingView(const IntRect& localRect) const { return localRect; }
+ virtual IntRect convertFromContainingView(const IntRect& localRect) const { return localRect; }
+ virtual IntPoint convertToContainingView(const IntPoint& localPoint) const { return localPoint; }
+ virtual IntPoint convertFromContainingView(const IntPoint& localPoint) const { return localPoint; }
private:
Widget* m_parent;

Powered by Google App Engine
This is Rietveld 408576698