Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Issue 684273002: Remove last non-third_party typeofs on Mac. (Closed)

Created:
6 years, 1 month ago by Nico
Modified:
6 years, 1 month ago
CC:
chromium-reviews, darin-cc_chromium.org, peter+watch_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Remove last non-third_party typeofs on Mac. BUG=427584 Committed: https://crrev.com/e6e95d9e01542a10db9611bb96025913df5a4356 Cr-Commit-Position: refs/heads/master@{#301948}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -12 lines) Patch
M ipc/ipc_message_macros.h View 1 chunk +1 line, -9 lines 0 comments Download
M ppapi/tests/test_broker.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M ui/message_center/cocoa/tray_controller.mm View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (3 generated)
Nico
jam: ipc raymes: ppapi/tests rsesek: ui/message_center/cocoa
6 years, 1 month ago (2014-10-29 18:54:19 UTC) #2
Robert Sesek
LGMT
6 years, 1 month ago (2014-10-29 18:55:49 UTC) #3
Robert Sesek
LGTM
6 years, 1 month ago (2014-10-29 18:56:03 UTC) #4
teravest
lgtm
6 years, 1 month ago (2014-10-29 19:52:08 UTC) #6
jam
nice, lgtm
6 years, 1 month ago (2014-10-29 19:54:47 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/684273002/1
6 years, 1 month ago (2014-10-29 19:56:05 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 1 month ago (2014-10-29 22:04:57 UTC) #10
commit-bot: I haz the power
6 years, 1 month ago (2014-10-29 22:05:46 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e6e95d9e01542a10db9611bb96025913df5a4356
Cr-Commit-Position: refs/heads/master@{#301948}

Powered by Google App Engine
This is Rietveld 408576698