Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(65)

Issue 684263002: Fix lo_space initialization for external snapshot (Closed)

Created:
6 years, 1 month ago by baixo
Modified:
6 years, 1 month ago
Reviewers:
rmcilroy, vogelheim, Yang
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

Fix lo_space initialization for external snapshot R=rmcilroy@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=24998

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M src/snapshot-external.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
baixo1
Please take a look.
6 years, 1 month ago (2014-10-29 18:25:52 UTC) #2
rmcilroy
lgtm, thanks. +vogelheim / yangguo - could we add some external snapshot tests to ensure ...
6 years, 1 month ago (2014-10-29 23:25:27 UTC) #4
rmcilroy
Committed patchset #1 (id:1) manually as 24998 (presubmit successful).
6 years, 1 month ago (2014-10-29 23:27:15 UTC) #5
Yang
6 years, 1 month ago (2014-10-30 06:09:30 UTC) #6
Message was sent while issue was closed.
On 2014/10/29 23:27:15, rmcilroy wrote:
> Committed patchset #1 (id:1) manually as 24998 (presubmit successful).

Yup. It sounds like we need more test coverage for external snapshots. Daniel,
do you want to do this?

Powered by Google App Engine
This is Rietveld 408576698