Return correct length for firstLetterLength.

Return correct length for firstLetterLength.

Currently if the text passed into firstLetterLength has a length of 0 we will
return a length of 1. This is wrong as we should be returning a length of 0.

This CL fixes the code to check or the length and then fixes the caller to
correctly handle the cases where needed the length to be 1 instead of the
correct 0.

Also, LayoutTests were added to show we correctly handle a <br> and <wbr>
as the first character in the div when looking for the first-letter renderer.

BUG=425008
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=184658

[dsinclair, 2014-10-29 15:52:08]

Patchset #1 (id:1) has been deleted

[dsinclair, 2014-10-29 15:52:19]

Patchset #1 (id:20001) has been deleted

[dsinclair, 2014-10-29 15:52:53]

dsinclair@chromium.org changed reviewers:
+ dglazkov@chromium.org, esprehn@chromium.org, leviw@chromium.org

[dsinclair, 2014-10-29 15:52:53]

PTAL.

[dsinclair, 2014-10-29 20:10:23]

dsinclair@chromium.org changed reviewers:
+ jchaffraix@chromium.org

[leviw_travelin_and_unemployed, 2014-10-29 20:26:52]

"Aswell" and "correclty" in description.

LGTM.

https://codereview.chromium.org/684213002/diff/40001/Source/core/rendering/Re...
File Source/core/rendering/RenderBlock.cpp (right):

https://codereview.chromium.org/684213002/diff/40001/Source/core/rendering/Re...
Source/core/rendering/RenderBlock.cpp:3736: if (length || (currChild->isBR() ||
(currChild->isText() && toRenderText(currChild)->isWordBreak())))
Can you extract these cases into a static named function to make this code
clearer?

[dsinclair, 2014-10-30 14:07:27]

https://codereview.chromium.org/684213002/diff/40001/Source/core/rendering/Re...
File Source/core/rendering/RenderBlock.cpp (right):

https://codereview.chromium.org/684213002/diff/40001/Source/core/rendering/Re...
Source/core/rendering/RenderBlock.cpp:3736: if (length || (currChild->isBR() ||
(currChild->isText() && toRenderText(currChild)->isWordBreak())))
On 2014/10/29 20:26:52, leviw wrote:
> Can you extract these cases into a static named function to make this code
> clearer?

Done.

[dsinclair, 2014-10-30 14:08:12]

The CQ bit was checked by dsinclair@chromium.org

[commit-bot: I haz the power, 2014-10-30 14:08:43]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/684213002/80001

[commit-bot: I haz the power, 2014-10-30 15:55:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-10-30 15:55:48]

Try jobs failed on following builders:
  win_blink_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/34385)

[dsinclair, 2014-10-30 15:58:07]

The CQ bit was checked by dsinclair@chromium.org

[commit-bot: I haz the power, 2014-10-30 15:58:40]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/684213002/80001

[commit-bot: I haz the power, 2014-10-30 16:43:13]

Committed patchset #3 (id:80001) as 184658