Fix not localized strings in extension_error_reporter.cc

Fix not localized strings in extension_error_reporter.cc

These strings form a message box which is shown when drag-n-dropping an
extension onto chrome://extensions. This message is the same as the one
shown when loading an extension through "Load unpacked extension..."
button but it is not localized.

R=rdevlin.cronin@chromium.org

Committed: https://crrev.com/2443c2dffe32bbd9ccb12f7b196df87c52fdb132
Cr-Commit-Position: refs/heads/master@{#302305}

[Devlin, 2014-10-29 15:54:42]

It's kind of weird that we localize the title and first sentence, but not the
error itself (the latter is a deliberate decision so that googling the error
message returns useful results).  That said, we should probably be consistent
with the unpacked loader, which does use the localized strings.

lgtm.

[Stanislav Albreht, 2014-10-30 05:40:29]

Devlin, thanks for review!

It's worth noting that actual errors that are shown in both cases were already
localized (IDS_EXTENSION_LOAD_ICON_FAILED for example), so the message in
message box becomes consistent with itself with this patch.

[Stanislav Albreht, 2014-10-30 05:40:35]

The CQ bit was checked by fatalerr@yandex-team.ru

[commit-bot: I haz the power, 2014-10-30 05:41:39]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/684153002/1

[commit-bot: I haz the power, 2014-10-30 06:28:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-10-30 06:28:16]

Try jobs failed on following builders:
  linux_chromium_rel on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Stanislav Albreht, 2014-10-30 07:35:54]

Fixed related unit test.

[Devlin, 2014-10-30 15:38:58]

https://codereview.chromium.org/684153002/diff/20001/chrome/browser/extension...
File chrome/browser/extensions/extension_service_unittest.cc (right):

https://codereview.chromium.org/684153002/diff/20001/chrome/browser/extension...
chrome/browser/extensions/extension_service_unittest.cc:1315:
std::string("Failed to load extension from: *. ") +
This makes the tests rely on the bots running in English which, while probably
the case, shouldn't be an assumption.  These should also use the i18n'd version.

[Stanislav Albreht, 2014-10-31 07:46:35]

>
https://codereview.chromium.org/684153002/diff/20001/chrome/browser/extension...
> chrome/browser/extensions/extension_service_unittest.cc:1315:
> std::string("Failed to load extension from: *. ") +
> This makes the tests rely on the bots running in English which, while probably
> the case, shouldn't be an assumption.  These should also use the i18n'd
version.

Done. I thought it was correct because I saw it in other unit tests.

[Devlin, 2014-10-31 16:12:13]

On 2014/10/31 07:46:35, Stanislav Albreht wrote:
> >
>
https://codereview.chromium.org/684153002/diff/20001/chrome/browser/extension...
> > chrome/browser/extensions/extension_service_unittest.cc:1315:
> > std::string("Failed to load extension from: *. ") +
> > This makes the tests rely on the bots running in English which, while
probably
> > the case, shouldn't be an assumption.  These should also use the i18n'd
> version.
> 
> Done. I thought it was correct because I saw it in other unit tests.

I'm running your change through a few of the trybots.  If they pass, I'm happy
with it. :)

[Stanislav Albreht, 2014-10-31 18:31:10]

The CQ bit was checked by fatalerr@yandex-team.ru

[commit-bot: I haz the power, 2014-10-31 18:32:52]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/684153002/40001

[commit-bot: I haz the power, 2014-10-31 19:14:42]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2014-10-31 19:16:13]

Patchset 3 (id:??) landed as
https://crrev.com/2443c2dffe32bbd9ccb12f7b196df87c52fdb132
Cr-Commit-Position: refs/heads/master@{#302305}