Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1298)

Unified Diff: chrome/browser/extensions/extension_service_unittest.cc

Issue 684153002: Fix not localized strings in extension_error_reporter.cc (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Localization in unit test Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/extensions/extension_error_reporter.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/extensions/extension_service_unittest.cc
diff --git a/chrome/browser/extensions/extension_service_unittest.cc b/chrome/browser/extensions/extension_service_unittest.cc
index 3e8614e81a004ed7608f70d19d1f7e8242f837a0..9edf9b39d4875b2b1f5e97addf63263d94a34c8f 100644
--- a/chrome/browser/extensions/extension_service_unittest.cc
+++ b/chrome/browser/extensions/extension_service_unittest.cc
@@ -107,6 +107,7 @@
#include "extensions/common/value_builder.h"
#include "gpu/config/gpu_info.h"
#include "grit/browser_resources.h"
+#include "grit/generated_resources.h"
#include "net/cookies/canonical_cookie.h"
#include "net/cookies/cookie_monster.h"
#include "net/cookies/cookie_options.h"
@@ -126,6 +127,7 @@
#include "sync/protocol/sync.pb.h"
#include "testing/gtest/include/gtest/gtest.h"
#include "testing/platform_test.h"
+#include "ui/base/l10n/l10n_util.h"
#include "url/gurl.h"
#if defined(ENABLE_MANAGED_USERS)
@@ -1312,22 +1314,22 @@ TEST_F(ExtensionServiceTest, LoadAllExtensionsFromDirectoryFail) {
ASSERT_EQ(0u, loaded_.size());
EXPECT_TRUE(MatchPattern(base::UTF16ToUTF8(GetErrors()[0]),
- std::string("Could not load extension from '*'. ") +
+ l10n_util::GetStringUTF8(IDS_EXTENSIONS_LOAD_ERROR_MESSAGE) + " *. " +
extensions::manifest_errors::kManifestUnreadable)) <<
base::UTF16ToUTF8(GetErrors()[0]);
EXPECT_TRUE(MatchPattern(base::UTF16ToUTF8(GetErrors()[1]),
- std::string("Could not load extension from '*'. ") +
+ l10n_util::GetStringUTF8(IDS_EXTENSIONS_LOAD_ERROR_MESSAGE) + " *. " +
extensions::manifest_errors::kManifestUnreadable)) <<
base::UTF16ToUTF8(GetErrors()[1]);
EXPECT_TRUE(MatchPattern(base::UTF16ToUTF8(GetErrors()[2]),
- std::string("Could not load extension from '*'. ") +
+ l10n_util::GetStringUTF8(IDS_EXTENSIONS_LOAD_ERROR_MESSAGE) + " *. " +
extensions::manifest_errors::kMissingFile)) <<
base::UTF16ToUTF8(GetErrors()[2]);
EXPECT_TRUE(MatchPattern(base::UTF16ToUTF8(GetErrors()[3]),
- std::string("Could not load extension from '*'. ") +
+ l10n_util::GetStringUTF8(IDS_EXTENSIONS_LOAD_ERROR_MESSAGE) + " *. " +
extensions::manifest_errors::kManifestUnreadable)) <<
base::UTF16ToUTF8(GetErrors()[3]);
};
« no previous file with comments | « chrome/browser/extensions/extension_error_reporter.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698