Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(577)

Unified Diff: content/renderer/render_frame_impl.cc

Issue 684143002: Invalidate the previous frame when the window object is cleared. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Use didCreateNewDocument notification Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/renderer/render_frame_impl.h ('k') | extensions/renderer/script_injection_manager.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/renderer/render_frame_impl.cc
diff --git a/content/renderer/render_frame_impl.cc b/content/renderer/render_frame_impl.cc
index b99f8a0d556e9858c64ce244be4d0773e57d4f08..42e4ea5b270cf854a2bdfe9330097bd54c526ce0 100644
--- a/content/renderer/render_frame_impl.cc
+++ b/content/renderer/render_frame_impl.cc
@@ -2357,6 +2357,13 @@ void RenderFrameImpl::didCommitProvisionalLoad(
UpdateEncoding(frame, frame->view()->pageEncoding().utf8());
}
+void RenderFrameImpl::didCreateNewDocument(blink::WebLocalFrame* frame) {
+ DCHECK(!frame_ || frame_ == frame);
dcheng 2014/11/11 16:50:16 This assert should be more aggressive. We should n
robwu 2014/11/11 21:43:59 This DCHECK does not test whether the passed-in po
+
+ FOR_EACH_OBSERVER(RenderViewObserver, render_view_->observers(),
+ DidCreateNewDocument(frame));
+}
+
void RenderFrameImpl::didClearWindowObject(blink::WebLocalFrame* frame) {
DCHECK(!frame_ || frame_ == frame);
// TODO(nasko): Move implementation here. Needed state:
« no previous file with comments | « content/renderer/render_frame_impl.h ('k') | extensions/renderer/script_injection_manager.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698