Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(117)

Unified Diff: extensions/renderer/script_injection_manager.cc

Issue 684143002: Invalidate the previous frame when the window object is cleared. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Use didCreateNewDocument notification Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: extensions/renderer/script_injection_manager.cc
diff --git a/extensions/renderer/script_injection_manager.cc b/extensions/renderer/script_injection_manager.cc
index 436c4d00a0fd7e5c1f7f61d0fdf71fac148be73d..016f2b3d3e2e632712b2ebf195cb24571cd42926 100644
--- a/extensions/renderer/script_injection_manager.cc
+++ b/extensions/renderer/script_injection_manager.cc
@@ -41,10 +41,10 @@ class ScriptInjectionManager::RVOHelper : public content::RenderViewObserver {
private:
// RenderViewObserver implementation.
bool OnMessageReceived(const IPC::Message& message) override;
+ void DidCreateNewDocument(blink::WebLocalFrame* frame) override;
void DidCreateDocumentElement(blink::WebLocalFrame* frame) override;
void DidFinishDocumentLoad(blink::WebLocalFrame* frame) override;
void DidFinishLoad(blink::WebLocalFrame* frame) override;
- void DidStartProvisionalLoad(blink::WebLocalFrame* frame) override;
void FrameDetached(blink::WebFrame* frame) override;
void OnDestruct() override;
@@ -99,6 +99,12 @@ bool ScriptInjectionManager::RVOHelper::OnMessageReceived(
return handled;
}
+void ScriptInjectionManager::RVOHelper::DidCreateNewDocument(
+ blink::WebLocalFrame* frame) {
+ // A new document is going to be shown, so invalidate the old document state.
+ InvalidateFrame(frame);
+}
+
void ScriptInjectionManager::RVOHelper::DidCreateDocumentElement(
blink::WebLocalFrame* frame) {
manager_->InjectScripts(frame, UserScript::DOCUMENT_START);
@@ -137,12 +143,6 @@ void ScriptInjectionManager::RVOHelper::DidFinishLoad(
frame));
}
-void ScriptInjectionManager::RVOHelper::DidStartProvisionalLoad(
- blink::WebLocalFrame* frame) {
- // We're starting a new load - invalidate.
- InvalidateFrame(frame);
-}
-
void ScriptInjectionManager::RVOHelper::FrameDetached(blink::WebFrame* frame) {
// The frame is closing - invalidate.
InvalidateFrame(frame);
« content/renderer/render_frame_impl.cc ('K') | « content/renderer/render_frame_impl.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698