Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(217)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 684133002: [Android] Fix gn build for instrumentation tests. (Closed)

Created:
6 years, 1 month ago by qsr
Modified:
6 years, 1 month ago
CC:
chromium-reviews, klundberg+watch_chromium.org, yfriedman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

[Android] Fix gn build for instrumentation tests. This fixes the following issue: - allow forwarder2 to compile with clang - Makes android executables position independant so that they can be run on android devices - Add missing BUILD.gn TBR=brettw@chromium.org Committed: https://crrev.com/cad816ee8f32cdec09c26bdc8fbbe881ceeb053d Cr-Commit-Position: refs/heads/master@{#302429}

Patch Set 1 #

Total comments: 6

Patch Set 2 : Follow review #

Total comments: 2

Patch Set 3 : Follow review #

Unified diffs Side-by-side diffs Delta from patch set Stats (+163 lines, -41 lines) Patch
A build/android/pylib/device/commands/BUILD.gn View 1 2 1 chunk +17 lines, -0 lines 0 comments Download
M build/android/pylib/device/commands/commands.gyp View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M build/config/BUILDCONFIG.gn View 1 chunk +3 lines, -0 lines 0 comments Download
M build/config/android/BUILD.gn View 1 chunk +5 lines, -0 lines 0 comments Download
M build/config/android/rules.gni View 1 2 3 chunks +7 lines, -1 line 0 comments Download
A tools/android/common/BUILD.gn View 1 chunk +15 lines, -0 lines 0 comments Download
M tools/android/common/adb_connection.cc View 2 chunks +1 line, -2 lines 0 comments Download
M tools/android/common/common.gyp View 1 2 1 chunk +4 lines, -0 lines 0 comments Download
M tools/android/common/net.cc View 1 chunk +1 line, -1 line 0 comments Download
A tools/android/forwarder2/BUILD.gn View 1 1 chunk +94 lines, -0 lines 0 comments Download
M tools/android/forwarder2/daemon.cc View 1 chunk +0 lines, -25 lines 0 comments Download
M tools/android/forwarder2/device_forwarder_main.cc View 1 chunk +1 line, -1 line 0 comments Download
M tools/android/forwarder2/forwarder.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M tools/android/forwarder2/forwarder.gyp View 1 2 3 chunks +6 lines, -0 lines 0 comments Download
M tools/android/forwarder2/forwarders_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M tools/android/forwarder2/host_forwarder_main.cc View 2 chunks +2 lines, -5 lines 0 comments Download
M tools/android/forwarder2/socket.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 13 (3 generated)
qsr
cjhopman@ -> full review craigdh@ -> OWNER review for build/android/pylib/device brettw@ -> OWNER review for ...
6 years, 1 month ago (2014-10-29 10:28:58 UTC) #2
cjhopman
Could you add a { 'variables': { 'chromium_code': 1 } } block to the top ...
6 years, 1 month ago (2014-10-29 17:21:24 UTC) #3
qsr
https://codereview.chromium.org/684133002/diff/1/build/android/pylib/device/commands/BUILD.gn File build/android/pylib/device/commands/BUILD.gn (right): https://codereview.chromium.org/684133002/diff/1/build/android/pylib/device/commands/BUILD.gn#newcode22 build/android/pylib/device/commands/BUILD.gn:22: sources = ["$target_gen_dir/chromium_commands.dex.jar"] On 2014/10/29 17:21:24, cjhopman wrote: > ...
6 years, 1 month ago (2014-10-30 12:15:53 UTC) #4
cjhopman
lgtm
6 years, 1 month ago (2014-10-30 18:36:00 UTC) #5
klundberg
- craigdh who hasn't been on the team in a while + jbudorick who owns ...
6 years, 1 month ago (2014-10-30 20:59:36 UTC) #7
jbudorick
b/a/pylib/device lgtm w/ nit note that this overlaps with https://codereview.chromium.org/677483004/ https://codereview.chromium.org/684133002/diff/20001/build/android/pylib/device/commands/BUILD.gn File build/android/pylib/device/commands/BUILD.gn (right): https://codereview.chromium.org/684133002/diff/20001/build/android/pylib/device/commands/BUILD.gn#newcode14 ...
6 years, 1 month ago (2014-10-30 21:05:26 UTC) #8
qsr
brettw -> gentle ping? https://codereview.chromium.org/684133002/diff/20001/build/android/pylib/device/commands/BUILD.gn File build/android/pylib/device/commands/BUILD.gn (right): https://codereview.chromium.org/684133002/diff/20001/build/android/pylib/device/commands/BUILD.gn#newcode14 build/android/pylib/device/commands/BUILD.gn:14: # GYP: //build/android/pylib/device/commands/commands.gyp:chromium_commands On 2014/10/30 ...
6 years, 1 month ago (2014-10-31 09:15:01 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/684133002/40001
6 years, 1 month ago (2014-11-03 14:25:43 UTC) #11
commit-bot: I haz the power
Committed patchset #3 (id:40001)
6 years, 1 month ago (2014-11-03 15:37:32 UTC) #12
commit-bot: I haz the power
6 years, 1 month ago (2014-11-03 15:38:10 UTC) #13
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/cad816ee8f32cdec09c26bdc8fbbe881ceeb053d
Cr-Commit-Position: refs/heads/master@{#302429}

Powered by Google App Engine
This is Rietveld 408576698