tools/android/forwarder2/device_forwarder_main.cc - Issue 684133002: [Android] Fix gn build for instrumentation tests.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/android/forwarder2/device_forwarder_main.cc

Issue 684133002: [Android] Fix gn build for instrumentation tests. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Follow review Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/android/forwarder2/device_forwarder_main.cc

diff --git a/tools/android/forwarder2/device_forwarder_main.cc b/tools/android/forwarder2/device_forwarder_main.cc

index aeb2853c11794cf07f51abb0fe95e6a018023acd..be99aeb501757fb1df03bb2f9aff3edaa7bbdc82 100644

--- a/tools/android/forwarder2/device_forwarder_main.cc

+++ b/tools/android/forwarder2/device_forwarder_main.cc

@@ -124,7 +124,7 @@ class ClientDelegate : public Daemon::ClientDelegate {

const int bytes_read = daemon_socket->Read(

buf, sizeof(buf) - 1 /* leave space for null terminator */);

CHECK_GT(bytes_read, 0);

- DCHECK(bytes_read < sizeof(buf));

+ DCHECK(static_cast<unsigned int>(bytes_read) < sizeof(buf));

buf[bytes_read] = 0;

base::StringPiece msg(buf, bytes_read);

if (msg.starts_with("ERROR")) {

« no previous file with comments | « tools/android/forwarder2/daemon.cc ('k') | tools/android/forwarder2/forwarder.cc » ('j') | no next file with comments »