Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(602)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 684103002: allow disabling of ArrayBuffer neutering (Closed)

Created:
6 years, 1 month ago by dcarney
Modified:
6 years, 1 month ago
CC:
v8-dev, Paweł Hajdan Jr.
Project:
v8
Visibility:
Public.

Description

allow disabling of ArrayBuffer neutering BUG= R=dslomov@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=24973

Patch Set 1 : #

Total comments: 3

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+49 lines, -2 lines) Patch
M include/v8.h View 1 chunk +6 lines, -1 line 0 comments Download
M src/api.cc View 1 2 chunks +7 lines, -0 lines 0 comments Download
M src/objects.h View 2 chunks +4 lines, -0 lines 0 comments Download
M src/objects.cc View 1 1 chunk +3 lines, -1 line 0 comments Download
M src/objects-inl.h View 1 chunk +10 lines, -0 lines 0 comments Download
M src/runtime/runtime-typedarray.cc View 1 chunk +1 line, -0 lines 0 comments Download
M test/cctest/test-api.cc View 1 chunk +18 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (4 generated)
Dmitry Lomov (no reviews)
lgtm % comments https://codereview.chromium.org/684103002/diff/60001/include/v8.h File include/v8.h (right): https://codereview.chromium.org/684103002/diff/60001/include/v8.h#newcode2967 include/v8.h:2967: * ArrayBuffer should have been externalized ...
6 years, 1 month ago (2014-10-29 10:15:38 UTC) #5
Dmitry Lomov (no reviews)
lgtm
6 years, 1 month ago (2014-10-29 10:25:26 UTC) #6
dcarney
6 years, 1 month ago (2014-10-29 10:36:49 UTC) #7
Message was sent while issue was closed. 
Committed patchset #2 (id:80001) manually as 24973 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698