src/objects.cc - Issue 684103002: allow disabling of ArrayBuffer neutering

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/objects.cc

Issue 684103002: allow disabling of ArrayBuffer neutering (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/objects.cc

diff --git a/src/objects.cc b/src/objects.cc

index c0814a80cb0e184db7cc4e880a697b560bd85a11..ea07582481a4baff42ad7f8e9a24978991a3a2e9 100644

--- a/src/objects.cc

+++ b/src/objects.cc

@@ -16365,13 +16365,15 @@ void JSDate::SetCachedFields(int64_t local_time_ms, DateCache* date_cache) {

void JSArrayBuffer::Neuter() {

- DCHECK(is_external());

+ CHECK(is_neuterable());

+ CHECK(is_external());

set_backing_store(NULL);

set_byte_length(Smi::FromInt(0));

}

void JSArrayBufferView::NeuterView() {

+ CHECK(JSArrayBuffer::cast(buffer())->is_neuterable());

set_byte_offset(Smi::FromInt(0));

set_byte_length(Smi::FromInt(0));

}

« no previous file with comments | « src/objects.h ('k') | src/objects-inl.h » ('j') | no next file with comments »