Issue 684043002: Protect against the divide by zero error in QuicBandwidth::TransferTime.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 684043002: Protect against the divide by zero error in QuicBandwidth::TransferTime. (Closed)

Created:
6 years, 1 month ago by ramant (doing other things)

Modified:
6 years, 1 month ago

Reviewers:
Ryan Hamilton

CC:
chromium-reviews, cbentzel+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@Add_QUIC_connection_option_NTLP_78465187

Project:
chromium

Visibility:
Public.

More Reviews

Description

Protect against the divide by zero error in QuicBandwidth::TransferTime. Currently some send algorithms may return QuicBandwidth::Zero. Merge internal change: 78578198 R=rch@chromium.org

Patch Set 1 #

Created: 6 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+5 lines, -0 lines)			Patch
M	net/quic/congestion_control/send_algorithm_interface.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	net/quic/quic_bandwidth.cc	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	net/quic/quic_bandwidth_test.cc	View	1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

lgtm

Expand Messages | Collapse Messages