net/quic/quic_bandwidth_test.cc - Issue 684043002: Protect against the divide by zero error in QuicBandwidth::TransferTime.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: net/quic/quic_bandwidth_test.cc

Issue 684043002: Protect against the divide by zero error in QuicBandwidth::TransferTime. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@Add_QUIC_connection_option_NTLP_78465187

Patch Set: Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « net/quic/quic_bandwidth.cc ('k') | no next file » | no next file with comments »

OLD	NEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.	1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #include "net/quic/quic_bandwidth.h"	5 #include "net/quic/quic_bandwidth.h"

6 #include "testing/gtest/include/gtest/gtest.h"	6 #include "testing/gtest/include/gtest/gtest.h"

7	7

8 namespace net {	8 namespace net {

9 namespace test {	9 namespace test {

10	10

(...skipping 63 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
74 QuicTime::Delta::FromMilliseconds(1)));	74 QuicTime::Delta::FromMilliseconds(1)));

75 EXPECT_EQ(200000u, QuicBandwidth::FromKBytesPerSecond(2000).ToBytesPerPeriod(	75 EXPECT_EQ(200000u, QuicBandwidth::FromKBytesPerSecond(2000).ToBytesPerPeriod(

76 QuicTime::Delta::FromMilliseconds(100)));	76 QuicTime::Delta::FromMilliseconds(100)));

77 EXPECT_EQ(200u, QuicBandwidth::FromKBytesPerSecond(2000).ToKBytesPerPeriod(	77 EXPECT_EQ(200u, QuicBandwidth::FromKBytesPerSecond(2000).ToKBytesPerPeriod(

78 QuicTime::Delta::FromMilliseconds(100)));	78 QuicTime::Delta::FromMilliseconds(100)));

79 }	79 }

80	80

81 TEST_F(QuicBandwidthTest, TransferTime) {	81 TEST_F(QuicBandwidthTest, TransferTime) {

82 EXPECT_EQ(QuicTime::Delta::FromSeconds(1),	82 EXPECT_EQ(QuicTime::Delta::FromSeconds(1),

83 QuicBandwidth::FromKBytesPerSecond(1).TransferTime(1000));	83 QuicBandwidth::FromKBytesPerSecond(1).TransferTime(1000));

	84 EXPECT_EQ(QuicTime::Delta::Zero(), QuicBandwidth::Zero().TransferTime(1000));

84 }	85 }

85	86

86 } // namespace test	87 } // namespace test

87 } // namespace net	88 } // namespace net

OLD	NEW