Clip mask manager moved to ClipTarget

BUG=skia:

Committed: https://skia.googlesource.com/skia/+/329bf4862e9d5e05363c2b071d8ca475a0ef1952

[joshualitt, 2014-10-28 16:30:31]

joshualitt@google.com changed reviewers:
+ bsalomon@google.com

[bsalomon, 2014-10-28 17:53:28]

lgtm with a request for a comment and a question.

https://codereview.chromium.org/683933003/diff/40001/src/gpu/GrClipMaskManager.h
File src/gpu/GrClipMaskManager.h (right):

https://codereview.chromium.org/683933003/diff/40001/src/gpu/GrClipMaskManage...
src/gpu/GrClipMaskManager.h:96: enum PrivateDrawStateStateBits {
Maybe this sbould be in ClipTarget? Or does clip target give us a better way of
specifying this?

https://codereview.chromium.org/683933003/diff/40001/src/gpu/GrDrawTarget.h
File src/gpu/GrDrawTarget.h (right):

https://codereview.chromium.org/683933003/diff/40001/src/gpu/GrDrawTarget.h#n...
src/gpu/GrDrawTarget.h:945: class GrClipTarget : public GrDrawTarget {
This class needs a comment about why it exists.

[joshualitt, 2014-10-28 19:45:55]

Patchset #4 (id:50001) has been deleted

[joshualitt, 2014-10-28 19:50:30]

joshualitt@google.com changed reviewers:
+ joshualitt@google.com

[joshualitt, 2014-10-28 19:50:30]

https://codereview.chromium.org/683933003/diff/40001/src/gpu/GrClipMaskManager.h
File src/gpu/GrClipMaskManager.h (right):

https://codereview.chromium.org/683933003/diff/40001/src/gpu/GrClipMaskManage...
src/gpu/GrClipMaskManager.h:96: enum PrivateDrawStateStateBits {
On 2014/10/28 17:53:28, bsalomon wrote:
> Maybe this sbould be in ClipTarget? Or does clip target give us a better way
of
> specifying this?

I'm not sure what you mean, I thought these are only used in GrClipMaskManager?

[bsalomon, 2014-10-28 19:54:09]

https://codereview.chromium.org/683933003/diff/40001/src/gpu/GrClipMaskManager.h
File src/gpu/GrClipMaskManager.h (right):

https://codereview.chromium.org/683933003/diff/40001/src/gpu/GrClipMaskManage...
src/gpu/GrClipMaskManager.h:96: enum PrivateDrawStateStateBits {
On 2014/10/28 19:50:30, joshualitt wrote:
> On 2014/10/28 17:53:28, bsalomon wrote:
> > Maybe this sbould be in ClipTarget? Or does clip target give us a better way
> of
> > specifying this?
> 
> I'm not sure what you mean, I thought these are only used in
GrClipMaskManager?

Right. Since this bit provides access to setting the clip bit via ClipTarget
which is not accessible via DrawTarget. It seems a little more appropriate to me
for the class that recognizes and implements the bit to define it rather than
the client who sets it. But I was also wondering if having a ClipTarget allows
for a better way of specifying this other than a private bit that gets jammed
into draw state. Maybe not, but that mechanism is pretty dirty.

[joshualitt, 2014-10-29 17:14:43]

The CQ bit was checked by joshualitt@google.com

[commit-bot: I haz the power, 2014-10-29 17:15:45]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/683933003/90001

[commit-bot: I haz the power, 2014-10-29 19:31:31]

Committed patchset #5 (id:90001) as 329bf4862e9d5e05363c2b071d8ca475a0ef1952