Eliminate resource leaks from zip::ZipFiles and

chrome/utility/chrome_content_utility_client.cc

Index: chrome/utility/chrome_content_utility_client.cc
diff --git a/chrome/utility/chrome_content_utility_client.cc b/chrome/utility/chrome_content_utility_client.cc
index a813cef5d3e35573a7c5e9fa26b08f5222105a9b..a448680ac18ef775d6e9f58a371b1be143688c0b 100644
--- a/chrome/utility/chrome_content_utility_client.cc
+++ b/chrome/utility/chrome_content_utility_client.cc
@@ -249,6 +249,7 @@ void ChromeContentUtilityClient::OnCreateZipFile(
     const base::FilePath& src_dir,
     const std::vector<base::FilePath>& src_relative_paths,
     const base::FileDescriptor& dest_fd) {
+  base::ScopedFD scoped_fd(dest_fd.fd);

[satorux1, 2014/11/14 02:27:51]

Maybe name it fd_closer to make it even clearer?

BTW, I wanted to make sure that closing here was the right thing to do, and
found the documentation in ipc/ipc_message_util.h:

// The received file descriptor will have the |auto_close| flag set to true. The
      
// code which handles the message is responsible for taking ownership of it.    
      
// File descriptors are OS resources and must be closed when no longer needed.  
      


Maybe add a comment like

// dest_fd should be closed in the function. See ipc/ipc_message_util.h for
details.

[jeremyspiegel, 2014/11/14 23:49:26]

Sure, sounds good.

   bool succeeded = true;
 
   // Check sanity of source relative paths. Reject if path is absolute or