Eliminate resource leaks from zip::ZipFiles and

chrome/utility/chrome_content_utility_client.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/utility/chrome_content_utility_client.h"
 
 #include "base/command_line.h"
 #include "base/files/file_path.h"
 #include "base/memory/ref_counted.h"
 #include "base/time/time.h"
@@ skipping 231 matching lines @@
 void ChromeContentUtilityClient::OnDecodeImage(
     const std::vector<unsigned char>& encoded_data, bool shrink_to_fit) {
   DecodeImageAndSend(encoded_data, shrink_to_fit);
 }
 
 #if defined(OS_CHROMEOS)
 void ChromeContentUtilityClient::OnCreateZipFile(
     const base::FilePath& src_dir,
     const std::vector<base::FilePath>& src_relative_paths,
     const base::FileDescriptor& dest_fd) {
+  base::ScopedFD scoped_fd(dest_fd.fd);

[satorux1, 2014/11/14 02:27:51]

Maybe name it fd_closer to make it even clearer?

BTW, I wanted to make sure that closing here was the right thing to do, and
found the documentation in ipc/ipc_message_util.h:

// The received file descriptor will have the |auto_close| flag set to true. The
      
// code which handles the message is responsible for taking ownership of it.    
      
// File descriptors are OS resources and must be closed when no longer needed.  
      


Maybe add a comment like

// dest_fd should be closed in the function. See ipc/ipc_message_util.h for
details.

[jeremyspiegel, 2014/11/14 23:49:26]

Sure, sounds good.

   bool succeeded = true;
 
   // Check sanity of source relative paths. Reject if path is absolute or
   // contains any attempt to reference a parent directory ("../" tricks).
   for (std::vector<base::FilePath>::const_iterator iter =
            src_relative_paths.begin(); iter != src_relative_paths.end();
        ++iter) {
     if (iter->IsAbsolute() || iter->ReferencesParent()) {
       succeeded = false;
       break;
@@ skipping 84 matching lines @@
     const std::string& mime_type, int64 total_size, bool get_attached_images) {
   // Only one IPCDataSource may be created and added to the list of handlers.
   metadata::IPCDataSource* source = new metadata::IPCDataSource(total_size);
   handlers_.push_back(source);
 
   metadata::MediaMetadataParser* parser = new metadata::MediaMetadataParser(
       source, mime_type, get_attached_images);
   parser->Start(base::Bind(&FinishParseMediaMetadata, base::Owned(parser)));
 }
 #endif