Chromium Code Reviews

Unified Diff: third_party/zlib/google/zip_reader.h

Issue 683913009: Eliminate resource leaks from zip::ZipFiles and (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
« third_party/zlib/google/zip_internal.cc ('K') | « third_party/zlib/google/zip_internal.cc ('k') | third_party/zlib/google/zip_reader_unittest.cc » ('j') | third_party/zlib/google/zip_reader_unittest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/zlib/google/zip_reader.h
diff --git a/third_party/zlib/google/zip_reader.h b/third_party/zlib/google/zip_reader.h
index cda9cf7e15baab362cfabffddf9f22fa6882b09c..9280f23029ed9f4ed395ed6a8819a95fa5d91445 100644
--- a/third_party/zlib/google/zip_reader.h
+++ b/third_party/zlib/google/zip_reader.h
@@ -102,8 +102,8 @@ class ZipReader {
// success.
bool Open(const base::FilePath& zip_file_path);
- // Opens the zip file referred to by the platform file |zip_fd|.
- // Returns true on success.
+ // Opens the zip file referred to by the platform file |zip_fd|, without
+ // taking ownership of |zip_fd|. Returns true on success.
bool OpenFromPlatformFile(base::PlatformFile zip_fd);
// Opens the zip data stored in |data|. This class uses a weak reference to
« third_party/zlib/google/zip_internal.cc ('K') | « third_party/zlib/google/zip_internal.cc ('k') | third_party/zlib/google/zip_reader_unittest.cc » ('j') | third_party/zlib/google/zip_reader_unittest.cc » ('J')

Powered by Google App Engine