Eliminate resource leaks from zip::ZipFiles and

third_party/zlib/google/zip_reader_unittest.cc

Index: third_party/zlib/google/zip_reader_unittest.cc
diff --git a/third_party/zlib/google/zip_reader_unittest.cc b/third_party/zlib/google/zip_reader_unittest.cc
index 09fc241bd6fc5fdcdf82449ed7953fa636d0a45e..2a66cc2b3ee34e522830b82f25df23505b2f3a25 100644
--- a/third_party/zlib/google/zip_reader_unittest.cc
+++ b/third_party/zlib/google/zip_reader_unittest.cc
@@ -180,8 +180,8 @@ TEST_F(ZipReaderTest, Open_ValidZipFile) {
 }
 
 TEST_F(ZipReaderTest, Open_ValidZipPlatformFile) {
-  ZipReader reader;
   FileWrapper zip_fd_wrapper(test_zip_file_, FileWrapper::READ_ONLY);

[satorux1, 2014/11/12 07:04:43]

does this have to be moved? otherwise, keep it-as-is?

[jeremyspiegel, 2014/11/12 08:52:51]

This doesn't have to be moved to work correctly, but since the ZipReader does
not take ownership of the file, I think it would be clearer to ensure the
FileWrapper outlives it. I think the unclear ownership semantics of
ZipReader::OpenFromPlatformFile may have led to one of the resource leaks, so in
addition to documenting it in the comment at the function declaration, I think
that changing the test case to be consistent would also help. If you'd prefer to
leave it as-is, that's fine too.

[satorux1, 2014/11/14 02:27:51]

I see. There are many places in the file where ZipReader is created before
FileWrapper (ex. PlatformFileIteration). We can fix everywhere but I guess it's
fine to leave them as-is

[jeremyspiegel, 2014/11/14 23:49:25]

Ah I missed those. Sounds good, I'll leave this as-is.

+  ZipReader reader;
   ASSERT_TRUE(reader.OpenFromPlatformFile(zip_fd_wrapper.platform_file()));
 }