Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Issue 6839008: Split EGLContext in GLContextEGL and GLSurfaceEGL. (Closed)

Created:
9 years, 8 months ago by apatrick_chromium
Modified:
9 years, 7 months ago
Reviewers:
Alexey Marinichev
CC:
chromium-reviews, jam, apatrick_chromium
Visibility:
Public.

Description

Split EGLContext in GLContextEGL and GLSurfaceEGL. Surfaces are independent of contexts in GL. To facilitate sharing of surfaces between processes, I have separated them from the notion of contexts because contexts cannot be shared between processes. I have started with EGL. GLContextEGL still has a pointer to a surface and still has some surface specific operations that just forward through to it. Once I have refactored all the GLContext implementations in this way, I will remove these pointers and the surface specific opertations. There will not be "view" and "offscreen" GL contexts. Rather there will be a single context type for each backend which can be made current with a surface that directs output either to a view or offscreen surface. TEST=try, WebGL puppy works BUG=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=81512

Patch Set 1 : '' #

Total comments: 2

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+216 lines, -1668 lines) Patch
M content/gpu/gpu_info_collector_win.cc View 2 chunks +2 lines, -2 lines 0 comments Download
A + ui/gfx/gl/egl_util.h View 1 chunk +5 lines, -422 lines 0 comments Download
A + ui/gfx/gl/egl_util.cc View 2 chunks +1 line, -386 lines 0 comments Download
M ui/gfx/gl/gl.gyp View 4 chunks +19 lines, -18 lines 0 comments Download
M ui/gfx/gl/gl_context_egl.h View 2 chunks +13 lines, -79 lines 0 comments Download
M ui/gfx/gl/gl_context_egl.cc View 4 chunks +36 lines, -328 lines 0 comments Download
M ui/gfx/gl/gl_context_linux.cc View 4 chunks +17 lines, -7 lines 0 comments Download
M ui/gfx/gl/gl_context_win.cc View 5 chunks +16 lines, -22 lines 0 comments Download
A + ui/gfx/gl/gl_surface.h View 1 chunk +18 lines, -44 lines 0 comments Download
A + ui/gfx/gl/gl_surface.cc View 1 chunk +2 lines, -47 lines 0 comments Download
A + ui/gfx/gl/gl_surface_egl.h View 1 1 chunk +29 lines, -68 lines 0 comments Download
A + ui/gfx/gl/gl_surface_egl.cc View 5 chunks +58 lines, -245 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
apatrick_chromium
Running by trybots now...
9 years, 8 months ago (2011-04-13 22:17:39 UTC) #1
Alexey Marinichev
http://codereview.chromium.org/6839008/diff/8001/ui/gfx/gl/gl_surface_egl.h File ui/gfx/gl/gl_surface_egl.h (right): http://codereview.chromium.org/6839008/diff/8001/ui/gfx/gl/gl_surface_egl.h#newcode9 ui/gfx/gl/gl_surface_egl.h:9: #include "base/memory/ref_counted.h" Should surfaces be refcounted? If they shouldn't, ...
9 years, 8 months ago (2011-04-13 23:45:07 UTC) #2
apatrick_chromium
http://codereview.chromium.org/6839008/diff/8001/ui/gfx/gl/gl_surface_egl.h File ui/gfx/gl/gl_surface_egl.h (right): http://codereview.chromium.org/6839008/diff/8001/ui/gfx/gl/gl_surface_egl.h#newcode9 ui/gfx/gl/gl_surface_egl.h:9: #include "base/memory/ref_counted.h" On 2011/04/13 23:45:07, Alexey Marinichev wrote: > ...
9 years, 8 months ago (2011-04-13 23:51:58 UTC) #3
Alexey Marinichev
9 years, 8 months ago (2011-04-14 00:00:30 UTC) #4
LGTM

Powered by Google App Engine
This is Rietveld 408576698