Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(584)

Unified Diff: sky/engine/platform/geometry/LayoutBoxExtent.h

Issue 683803006: Remove all writing mode function arguments and remove writing mode from RenderStyle. (Closed) Base URL: git@github.com:domokit/mojo.git@writingmode
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sky/engine/platform/LengthBox.cpp ('k') | sky/engine/platform/geometry/LayoutBoxExtent.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sky/engine/platform/geometry/LayoutBoxExtent.h
diff --git a/sky/engine/platform/geometry/LayoutBoxExtent.h b/sky/engine/platform/geometry/LayoutBoxExtent.h
index 376bfc963d447bddcc7b90520712135c7350ce85..bbc634b02b1bde3d17f523d792220b9ed2d086cd 100644
--- a/sky/engine/platform/geometry/LayoutBoxExtent.h
+++ b/sky/engine/platform/geometry/LayoutBoxExtent.h
@@ -54,26 +54,26 @@ public:
inline void setBottom(LayoutUnit value) { m_bottom = value; }
inline void setLeft(LayoutUnit value) { m_left = value; }
- LayoutUnit logicalTop(WritingMode) const;
- LayoutUnit logicalBottom(WritingMode) const;
- LayoutUnit logicalLeft(WritingMode) const;
- LayoutUnit logicalRight(WritingMode) const;
+ LayoutUnit logicalTop() const;
+ LayoutUnit logicalBottom() const;
+ LayoutUnit logicalLeft() const;
+ LayoutUnit logicalRight() const;
- LayoutUnit before(WritingMode) const;
- LayoutUnit after(WritingMode) const;
- LayoutUnit start(WritingMode, TextDirection) const;
- LayoutUnit end(WritingMode, TextDirection) const;
+ LayoutUnit before() const;
+ LayoutUnit after() const;
+ LayoutUnit start(TextDirection) const;
+ LayoutUnit end(TextDirection) const;
- void setBefore(WritingMode, LayoutUnit);
- void setAfter(WritingMode, LayoutUnit);
- void setStart(WritingMode, TextDirection, LayoutUnit);
- void setEnd(WritingMode, TextDirection, LayoutUnit);
+ void setBefore(LayoutUnit);
+ void setAfter(LayoutUnit);
+ void setStart(TextDirection, LayoutUnit);
+ void setEnd(TextDirection, LayoutUnit);
- LayoutUnit& mutableLogicalLeft(WritingMode);
- LayoutUnit& mutableLogicalRight(WritingMode);
+ LayoutUnit& mutableLogicalLeft();
+ LayoutUnit& mutableLogicalRight();
- LayoutUnit& mutableBefore(WritingMode);
- LayoutUnit& mutableAfter(WritingMode);
+ LayoutUnit& mutableBefore();
+ LayoutUnit& mutableAfter();
private:
LayoutUnit m_top;
« no previous file with comments | « sky/engine/platform/LengthBox.cpp ('k') | sky/engine/platform/geometry/LayoutBoxExtent.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698