Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(60)

Unified Diff: sky/engine/platform/LengthBox.cpp

Issue 683803006: Remove all writing mode function arguments and remove writing mode from RenderStyle. (Closed) Base URL: git@github.com:domokit/mojo.git@writingmode
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sky/engine/platform/LengthBox.h ('k') | sky/engine/platform/geometry/LayoutBoxExtent.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sky/engine/platform/LengthBox.cpp
diff --git a/sky/engine/platform/LengthBox.cpp b/sky/engine/platform/LengthBox.cpp
index 396fcc4cfb9ab5bdd0c82b519ad24e68368eabc9..c1341cda9250e0505ac373c419300a3763e23ef9 100644
--- a/sky/engine/platform/LengthBox.cpp
+++ b/sky/engine/platform/LengthBox.cpp
@@ -33,38 +33,38 @@
namespace blink {
-const Length& LengthBox::logicalLeft(WritingMode writingMode) const
+const Length& LengthBox::logicalLeft() const
{
- return isHorizontalWritingMode(writingMode) ? m_left : m_top;
+ return isHorizontalWritingMode() ? m_left : m_top;
}
-const Length& LengthBox::logicalRight(WritingMode writingMode) const
+const Length& LengthBox::logicalRight() const
{
- return isHorizontalWritingMode(writingMode) ? m_right : m_bottom;
+ return isHorizontalWritingMode() ? m_right : m_bottom;
}
-const Length& LengthBox::before(WritingMode writingMode) const
+const Length& LengthBox::before() const
{
// FIXME(sky): Remove
return m_top;
}
-const Length& LengthBox::after(WritingMode writingMode) const
+const Length& LengthBox::after() const
{
// FIXME(sky): Remove
return m_bottom;
}
-const Length& LengthBox::start(WritingMode writingMode, TextDirection direction) const
+const Length& LengthBox::start(TextDirection direction) const
{
- if (isHorizontalWritingMode(writingMode))
+ if (isHorizontalWritingMode())
return isLeftToRightDirection(direction) ? m_left : m_right;
return isLeftToRightDirection(direction) ? m_top : m_bottom;
}
-const Length& LengthBox::end(WritingMode writingMode, TextDirection direction) const
+const Length& LengthBox::end(TextDirection direction) const
{
- if (isHorizontalWritingMode(writingMode))
+ if (isHorizontalWritingMode())
return isLeftToRightDirection(direction) ? m_right : m_left;
return isLeftToRightDirection(direction) ? m_bottom : m_top;
}
« no previous file with comments | « sky/engine/platform/LengthBox.h ('k') | sky/engine/platform/geometry/LayoutBoxExtent.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698