sky/engine/core/css/resolver/StyleResolverState.h - Issue 683803006: Remove all writing mode function arguments and remove writing mode from RenderStyle.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sky/engine/core/css/resolver/StyleResolverState.h

Issue 683803006: Remove all writing mode function arguments and remove writing mode from RenderStyle. (Closed) Base URL: git@github.com:domokit/mojo.git@writingmode

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: sky/engine/core/css/resolver/StyleResolverState.h

diff --git a/sky/engine/core/css/resolver/StyleResolverState.h b/sky/engine/core/css/resolver/StyleResolverState.h

index f9b82fed37e15ced960a4bbb2264ad9631394bcb..13292c7c356826364942654a9c5257dce076f412 100644

--- a/sky/engine/core/css/resolver/StyleResolverState.h

+++ b/sky/engine/core/css/resolver/StyleResolverState.h

@@ -101,7 +101,6 @@ public:

const FontDescription& parentFontDescription() { return m_parentStyle->fontDescription(); }

void setZoom(float f) { m_fontBuilder.didChangeFontParameters(m_style->setZoom(f)); }

void setEffectiveZoom(float f) { m_fontBuilder.didChangeFontParameters(m_style->setEffectiveZoom(f)); }

- void setWritingMode(WritingMode writingMode) { m_fontBuilder.didChangeFontParameters(m_style->setWritingMode(writingMode)); }

void setTextOrientation(TextOrientation textOrientation) { m_fontBuilder.didChangeFontParameters(m_style->setTextOrientation(textOrientation)); }

private:

« no previous file with comments | « sky/engine/core/css/resolver/StyleResolver.cpp ('k') | sky/engine/core/dom/Document.h » ('j') | no next file with comments »