GrContext no longer ever draws on Gpu

GrContext no longer ever draws on Gpu

BUG=skia:

Committed: https://skia.googlesource.com/skia/+/7a75e5230872732e71ea99058d9afe5d4b6758b0

Committed: https://skia.googlesource.com/skia/+/5c55fef032d1de01fed6b40ac39081aea9544a75

[joshualitt, 2014-10-31 17:21:39]

joshualitt@google.com changed reviewers:
+ bsalomon@google.com, joshualitt@google.com

[bsalomon, 2014-10-31 17:35:17]

https://codereview.chromium.org/683733005/diff/60001/src/gpu/GrContext.cpp
File src/gpu/GrContext.cpp (right):

https://codereview.chromium.org/683733005/diff/60001/src/gpu/GrContext.cpp#ne...
src/gpu/GrContext.cpp:378: if (mustFlush) {
I don't think we need this flush

https://codereview.chromium.org/683733005/diff/60001/src/gpu/GrContext.cpp#ne...
src/gpu/GrContext.cpp:1520: if (!fGpu->readPixels(target,
Instead of flushing above I think we should call this->flushWrites(target) here.
That gives us an opportunity to do a limited flush if we think it's
advantageous.

[joshualitt, 2014-10-31 17:45:35]

feedback incorporated

[bsalomon, 2014-10-31 18:00:59]

https://codereview.chromium.org/683733005/diff/100001/src/gpu/GrContext.cpp
File src/gpu/GrContext.cpp (right):

https://codereview.chromium.org/683733005/diff/100001/src/gpu/GrContext.cpp#n...
src/gpu/GrContext.cpp:1508: this->flushSurfaceWrites(target);
Errr... I was a bit wrong about this.

We actually only want to flush when we used a scratch surface... not when we're
directly reading the target passed in.

We already handle the direct case at the top and we give the client an option to
skip the flush when they know what they're doing (e.g. they know they drew to a
part of the RT that isn't in the read rectangle). So I think this line should go
below 1503 since we cant't skip the flush when we're using a scratch surface
that the caller doesn't know about.

lgtm otherwise

[joshualitt, 2014-10-31 18:26:13]

The CQ bit was checked by joshualitt@google.com

[commit-bot: I haz the power, 2014-10-31 18:27:03]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/683733005/120001

[commit-bot: I haz the power, 2014-10-31 18:34:56]

Committed patchset #7 (id:120001) as 7a75e5230872732e71ea99058d9afe5d4b6758b0

[joshualitt, 2014-10-31 19:19:32]

A revert of this CL (patchset #7 id:120001) has been created in
https://codereview.chromium.org/694983002/ by joshualitt@google.com.

The reason for reverting is: breaks some android bots.

[joshualitt, 2014-10-31 20:56:23]

The CQ bit was checked by joshualitt@google.com

[commit-bot: I haz the power, 2014-10-31 20:56:38]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/683733005/140001

[commit-bot: I haz the power, 2014-10-31 21:04:38]

Committed patchset #8 (id:140001) as 5c55fef032d1de01fed6b40ac39081aea9544a75