clear stencil clip on draw target

clear stencil clip on draw target

TBR=
BUG=skia:

Committed: https://skia.googlesource.com/skia/+/6db519c42471aaaa8a8e1a3ece314014481ab832

[joshualitt, 2014-10-28 14:53:03]

joshualitt@google.com changed reviewers:
+ bsalomon@google.com, joshualitt@google.com

[bsalomon, 2014-10-28 15:08:01]

https://codereview.chromium.org/683673002/diff/20001/src/gpu/GrDrawTarget.h
File src/gpu/GrDrawTarget.h (right):

https://codereview.chromium.org/683673002/diff/20001/src/gpu/GrDrawTarget.h#n...
src/gpu/GrDrawTarget.h:428: virtual void clearStencilClip(const SkIRect& rect,
bool insideClip, GrRenderTarget* = NULL) = 0;
Does this need to be on GrDT or can it just be on GrGpu? I don't think this
should be exposed to any code that has a GrDT but should be called on GrGpu by
GrDT on behalf of GrCMM

[joshualitt, 2014-10-28 15:50:30]

feedback incorporated

[joshualitt, 2014-10-29 13:54:23]

On 2014/10/28 15:50:30, joshualitt wrote:
> feedback incorporated

Brian, any other feedback on this patch?

[bsalomon, 2014-10-29 14:46:51]

overall looks good, some minor suggestions.

https://codereview.chromium.org/683673002/diff/40001/src/gpu/GrClipMaskManager.h
File src/gpu/GrClipMaskManager.h (right):

https://codereview.chromium.org/683673002/diff/40001/src/gpu/GrClipMaskManage...
src/gpu/GrClipMaskManager.h:48: struct ScissorState {
I think this should be part of ClipTarget or Gpu

https://codereview.chromium.org/683673002/diff/40001/src/gpu/GrGpu.h
File src/gpu/GrGpu.h (right):

https://codereview.chromium.org/683673002/diff/40001/src/gpu/GrGpu.h#newcode419
src/gpu/GrGpu.h:419: // ONLY used by the clip mask manager
can we say only used by ClipTarget? I think we should think of ClipTarget as the
API for extending GrDT to support clipping and CMM as a particular
implementation that sits on top of that API. It's possible we could break up CMM
to different classes for different clipping approaches (mask, stencil, analytic)

[joshualitt, 2014-10-29 15:40:07]

The CQ bit was checked by joshualitt@google.com

[commit-bot: I haz the power, 2014-10-29 15:40:31]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/683673002/60001

[commit-bot: I haz the power, 2014-10-29 15:48:24]

Committed patchset #4 (id:60001) as 6db519c42471aaaa8a8e1a3ece314014481ab832