Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(416)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 683593002: Remove GarbageCollected support from the bindings (Closed)

Created:
6 years, 1 month ago by eseidel
Modified:
6 years, 1 month ago
Reviewers:
abarth-chromium
CC:
abarth-chromium, esprehn, mojo-reviews_chromium.org, ojan
Base URL:
git@github.com:domokit/mojo.git@master
Project:
mojo
Visibility:
Public.

Description

Remove GarbageCollected support from the bindings This was the last complicated piece of removing platform/heap, the rest should be trivial to delete after removing :trace overrides and mass-renaming the various WillBe types to their old versions. R=abarth@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/226f90ae35fa969293e991cab00f7cb07c0309f5

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -724 lines) Patch
M sky/engine/bindings/IDLExtendedAttributes.txt View 2 chunks +0 lines, -2 lines 0 comments Download
M sky/engine/bindings/core/v8/V8DOMWrapper.h View 6 chunks +2 lines, -68 lines 0 comments Download
M sky/engine/bindings/core/v8/WrapperTypeInfo.h View 6 chunks +2 lines, -40 lines 0 comments Download
M sky/engine/bindings/core/v8/custom/V8ArrayBufferCustom.h View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/bindings/core/v8/custom/V8ArrayBufferCustom.cpp View 2 chunks +0 lines, -8 lines 0 comments Download
M sky/engine/bindings/core/v8/custom/V8TypedArrayCustom.h View 3 chunks +0 lines, -10 lines 0 comments Download
M sky/engine/bindings/scripts/code_generator_v8.py View 1 chunk +0 lines, -8 lines 0 comments Download
M sky/engine/bindings/scripts/compute_interfaces_info_overall.py View 1 chunk +0 lines, -2 lines 0 comments Download
M sky/engine/bindings/scripts/v8_interface.py View 4 chunks +4 lines, -7 lines 0 comments Download
M sky/engine/bindings/scripts/v8_methods.py View 1 chunk +1 line, -1 line 0 comments Download
M sky/engine/bindings/scripts/v8_types.py View 5 chunks +3 lines, -45 lines 0 comments Download
M sky/engine/bindings/scripts/v8_utilities.py View 1 chunk +0 lines, -10 lines 0 comments Download
M sky/engine/bindings/templates/interface.h View 2 chunks +0 lines, -13 lines 0 comments Download
M sky/engine/bindings/templates/interface.cpp View 2 chunks +1 line, -30 lines 0 comments Download
M sky/engine/bindings/templates/interface_base.cpp View 1 chunk +1 line, -1 line 0 comments Download
M sky/engine/bindings/tests/idls/TestCallbackInterface.idl View 1 chunk +0 lines, -3 lines 0 comments Download
M sky/engine/bindings/tests/idls/TestDictionary.idl View 2 chunks +0 lines, -5 lines 0 comments Download
D sky/engine/bindings/tests/idls/TestInterfaceGarbageCollected.idl View 1 chunk +0 lines, -11 lines 0 comments Download
D sky/engine/bindings/tests/idls/TestInterfaceWillBeGarbageCollected.idl View 1 chunk +0 lines, -38 lines 0 comments Download
M sky/engine/bindings/tests/idls/TestObject.idl View 4 chunks +0 lines, -14 lines 0 comments Download
M sky/engine/core/animation/AnimationEffect.idl View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/core/animation/AnimationNode.idl View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/core/animation/AnimationPlayer.idl View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/core/animation/AnimationTimeline.idl View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/core/animation/Timing.idl View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/core/css/CSS.idl View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/core/css/CSSMatrix.idl View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/core/css/CSSRule.idl View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/core/css/CSSRuleList.idl View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/core/css/CSSStyleDeclaration.idl View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/core/css/CSSValue.idl View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/core/css/FontFace.idl View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/core/css/MediaList.idl View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/core/css/MediaQueryList.idl View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/core/css/RGBColor.idl View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/core/css/Rect.idl View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/core/css/StyleMedia.idl View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/core/css/StyleSheet.idl View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/core/css/StyleSheetList.idl View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/core/dom/ClientRect.idl View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/core/dom/ClientRectList.idl View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/core/dom/DOMError.idl View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/core/dom/DOMException.idl View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/core/dom/DOMImplementation.idl View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/core/dom/DOMStringList.idl View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/core/dom/DOMTokenList.idl View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/core/dom/MutationObserver.idl View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/core/dom/MutationRecord.idl View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/core/dom/NamedNodeMap.idl View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/core/dom/NodeList.idl View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/core/dom/Range.idl View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/core/dom/Touch.idl View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/core/dom/TouchList.idl View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/core/dom/URL.idl View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/core/editing/Selection.idl View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/core/events/Event.idl View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/core/events/EventTarget.idl View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/core/frame/ConsoleBase.idl View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/core/frame/History.idl View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/core/frame/ImageBitmap.idl View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/core/frame/Location.idl View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/core/frame/Screen.idl View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/core/frame/Window.idl View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/core/html/ImageData.idl View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/core/html/MediaError.idl View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/core/html/MediaKeyError.idl View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/core/html/TextMetrics.idl View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/core/html/TimeRanges.idl View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/core/html/canvas/ANGLEInstancedArrays.idl View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/core/html/canvas/Canvas2DContextAttributes.idl View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/core/html/canvas/CanvasGradient.idl View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/core/html/canvas/CanvasPattern.idl View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/core/html/canvas/CanvasRenderingContext2D.idl View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/core/html/canvas/EXTBlendMinMax.idl View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/core/html/canvas/EXTFragDepth.idl View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/core/html/canvas/EXTShaderTextureLOD.idl View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/core/html/canvas/EXTTextureFilterAnisotropic.idl View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/core/html/canvas/OESElementIndexUint.idl View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/core/html/canvas/OESStandardDerivatives.idl View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/core/html/canvas/OESTextureFloat.idl View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/core/html/canvas/OESTextureFloatLinear.idl View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/core/html/canvas/OESTextureHalfFloat.idl View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/core/html/canvas/OESTextureHalfFloatLinear.idl View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/core/html/canvas/OESVertexArrayObject.idl View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/core/html/canvas/Path2D.idl View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/core/html/canvas/WebGLActiveInfo.idl View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/core/html/canvas/WebGLBuffer.idl View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/core/html/canvas/WebGLCompressedTextureATC.idl View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/core/html/canvas/WebGLCompressedTextureETC1.idl View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/core/html/canvas/WebGLCompressedTexturePVRTC.idl View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/core/html/canvas/WebGLCompressedTextureS3TC.idl View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/core/html/canvas/WebGLContextAttributes.idl View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/core/html/canvas/WebGLDebugRendererInfo.idl View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/core/html/canvas/WebGLDebugShaders.idl View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/core/html/canvas/WebGLDepthTexture.idl View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/core/html/canvas/WebGLDrawBuffers.idl View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/core/html/canvas/WebGLFramebuffer.idl View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/core/html/canvas/WebGLLoseContext.idl View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/core/html/canvas/WebGLProgram.idl View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/core/html/canvas/WebGLRenderbuffer.idl View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/core/html/canvas/WebGLRenderingContext.idl View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/core/html/canvas/WebGLRenderingContextBase.idl View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/core/html/canvas/WebGLShader.idl View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/core/html/canvas/WebGLShaderPrecisionFormat.idl View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/core/html/canvas/WebGLTexture.idl View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/core/html/canvas/WebGLUniformLocation.idl View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/core/html/canvas/WebGLVertexArrayObjectOES.idl View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/platform/heap/Handle.h View 1 chunk +0 lines, -200 lines 0 comments Download
M sky/engine/platform/heap/Handle.cpp View 1 chunk +0 lines, -64 lines 0 comments Download
M sky/engine/platform/heap/ThreadState.h View 3 chunks +0 lines, -12 lines 0 comments Download
M sky/engine/platform/heap/ThreadState.cpp View 5 chunks +0 lines, -44 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
eseidel
6 years, 1 month ago (2014-10-27 20:38:27 UTC) #2
abarth-chromium
lgtm
6 years, 1 month ago (2014-10-27 20:38:46 UTC) #3
eseidel
6 years, 1 month ago (2014-10-27 20:39:41 UTC) #4
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
226f90ae35fa969293e991cab00f7cb07c0309f5 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698