sky/engine/bindings/scripts/code_generator_v8.py - Issue 683593002: Remove GarbageCollected support from the bindings

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sky/engine/bindings/scripts/code_generator_v8.py

Issue 683593002: Remove GarbageCollected support from the bindings (Closed) Base URL: git@github.com:domokit/mojo.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: sky/engine/bindings/scripts/code_generator_v8.py

diff --git a/sky/engine/bindings/scripts/code_generator_v8.py b/sky/engine/bindings/scripts/code_generator_v8.py

index 4677e0d8650a240758dfb7a7788f9d5074da8607..93e730b64e16a097e5ea7533708b0dd56b21906b 100644

--- a/sky/engine/bindings/scripts/code_generator_v8.py

+++ b/sky/engine/bindings/scripts/code_generator_v8.py

@@ -124,14 +124,6 @@ class CodeGeneratorBase(object):

(interface_name, interface_info['implemented_as'])

for interface_name, interface_info in interfaces_info.iteritems()

if interface_info['implemented_as']))

- IdlType.set_garbage_collected_types(set(

- interface_name

- for interface_name, interface_info in interfaces_info.iteritems()

- if 'GarbageCollected' in interface_info['inherited_extended_attributes']))

- IdlType.set_will_be_garbage_collected_types(set(

- interface_name

- for interface_name, interface_info in interfaces_info.iteritems()

- if 'WillBeGarbageCollected' in interface_info['inherited_extended_attributes']))

v8_types.set_component_dirs(dict(

(interface_name, interface_info['component_dir'])

for interface_name, interface_info in interfaces_info.iteritems()))