Issue 6835022: Broke ARM compile.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6835022: Broke ARM compile. (Closed)

Created:
9 years, 8 months ago by Sigurður Ásgeirsson

Modified:
9 years, 7 months ago

Reviewers:
tfarina

CC:
chromium-reviews, brettw-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Broke ARM compile. Revert 81409 - first-run: Refactor Upgrade class into a common upgrade_util 79203 TEST=NoneR=jhawkins@chromium.orgReview">API.BUG=79203 TEST=NoneR=jhawkins@chromium.orgReview URL: http://codereview.chromium.org/6840003 TBR=tfarina@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=81412

Patch Set 1 #

Created: 9 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+45 lines, -366 lines)			Patch
M	chrome/app/chrome_exe_main_gtk.cc	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/browser_main.cc	View	6 chunks	+10 lines, -10 lines	0 comments	Download
M	chrome/browser/browser_main_win.cc	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/browser_process_impl.cc	View	3 chunks	+3 lines, -3 lines	0 comments	Download
M	chrome/browser/browser_shutdown.cc	View	3 chunks	+4 lines, -4 lines	0 comments	Download
M	chrome/browser/first_run/try_chrome_dialog_view.h	View	3 chunks	+3 lines, -3 lines	0 comments	Download
M	chrome/browser/first_run/try_chrome_dialog_view.cc	View	5 chunks	+10 lines, -10 lines	0 comments	Download
A +	chrome/browser/first_run/upgrade.h	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	chrome/browser/first_run/upgrade.cc	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	chrome/browser/first_run/upgrade_gtk.cc	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
D	chrome/browser/first_run/upgrade_util.h	View	1 chunk	+0 lines, -83 lines	0 comments	Download
D	chrome/browser/first_run/upgrade_util.cc	View	1 chunk	+0 lines, -34 lines	0 comments	Download
D	chrome/browser/first_run/upgrade_util_linux.cc	View	1 chunk	+0 lines, -51 lines	0 comments	Download
D	chrome/browser/first_run/upgrade_util_win.cc	View	1 chunk	+0 lines, -152 lines	0 comments	Download
A +	chrome/browser/first_run/upgrade_win.cc	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
M	chrome/browser/process_singleton.h	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	chrome/chrome_browser.gypi	View	5 chunks	+12 lines, -12 lines	0 comments	Download
M	chrome/installer/setup/install_worker.cc	View	2 chunks	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages