Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(69)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 6840003: first-run: Refactor Upgrade class into a common upgrade_util API. (Closed)

Created:
9 years, 8 months ago by tfarina
Modified:
9 years, 7 months ago
Reviewers:
James Hawkins
CC:
chromium-reviews
Visibility:
Public.

Description

first-run: Refactor Upgrade class into a common upgrade_util API. BUG=79203 TEST=None R=jhawkins@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=81409

Patch Set 1 #

Total comments: 4

Patch Set 2 : upgrade_utils -> upgrade_util #

Unified diffs Side-by-side diffs Delta from patch set Stats (+209 lines, -429 lines) Patch
M chrome/app/chrome_exe_main_gtk.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/browser_main.cc View 1 6 chunks +10 lines, -10 lines 0 comments Download
M chrome/browser/browser_main_win.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/browser_process_impl.cc View 1 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/browser_shutdown.cc View 1 3 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/first_run/try_chrome_dialog_view.h View 1 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/first_run/try_chrome_dialog_view.cc View 1 5 chunks +10 lines, -10 lines 0 comments Download
D chrome/browser/first_run/upgrade.h View 1 chunk +0 lines, -96 lines 0 comments Download
D chrome/browser/first_run/upgrade.cc View 1 chunk +0 lines, -21 lines 0 comments Download
D chrome/browser/first_run/upgrade_gtk.cc View 1 chunk +0 lines, -55 lines 0 comments Download
A chrome/browser/first_run/upgrade_util.h View 1 1 chunk +83 lines, -0 lines 0 comments Download
A chrome/browser/first_run/upgrade_util.cc View 1 1 chunk +34 lines, -0 lines 0 comments Download
A + chrome/browser/first_run/upgrade_util_linux.cc View 1 2 chunks +16 lines, -20 lines 0 comments Download
A + chrome/browser/first_run/upgrade_util_win.cc View 1 4 chunks +26 lines, -31 lines 0 comments Download
D chrome/browser/first_run/upgrade_win.cc View 1 chunk +0 lines, -157 lines 0 comments Download
M chrome/browser/process_singleton.h View 1 1 chunk +2 lines, -1 line 0 comments Download
M chrome/chrome_browser.gypi View 1 5 chunks +12 lines, -12 lines 0 comments Download
M chrome/installer/setup/install_worker.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
tfarina
Please, take a look.
9 years, 8 months ago (2011-04-13 00:32:23 UTC) #1
James Hawkins
http://codereview.chromium.org/6840003/diff/1/chrome/app/chrome_exe_main_gtk.cc File chrome/app/chrome_exe_main_gtk.cc (right): http://codereview.chromium.org/6840003/diff/1/chrome/app/chrome_exe_main_gtk.cc#newcode9 chrome/app/chrome_exe_main_gtk.cc:9: #include "chrome/browser/first_run/upgrade_utils.h" s/utils/util/ http://codereview.chromium.org/6840003/diff/1/chrome/browser/first_run/upgrade_utils.h File chrome/browser/first_run/upgrade_utils.h (right): http://codereview.chromium.org/6840003/diff/1/chrome/browser/first_run/upgrade_utils.h#newcode71 chrome/browser/first_run/upgrade_utils.h:71: ...
9 years, 8 months ago (2011-04-13 00:49:08 UTC) #2
tfarina
http://codereview.chromium.org/6840003/diff/1/chrome/app/chrome_exe_main_gtk.cc File chrome/app/chrome_exe_main_gtk.cc (right): http://codereview.chromium.org/6840003/diff/1/chrome/app/chrome_exe_main_gtk.cc#newcode9 chrome/app/chrome_exe_main_gtk.cc:9: #include "chrome/browser/first_run/upgrade_utils.h" On 2011/04/13 00:49:08, James Hawkins wrote: > ...
9 years, 8 months ago (2011-04-13 01:06:37 UTC) #3
James Hawkins
9 years, 8 months ago (2011-04-13 01:10:30 UTC) #4 
LGTM

Powered by Google App Engine
This is Rietveld 408576698