Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(73)

Issue 683493004: Add mojo_system_unittest back to valgrind bots, which was removed by accident in https://codereview… (Closed)

Created:
6 years, 1 month ago by oshima
Modified:
6 years, 1 month ago
CC:
chromium-reviews, glider+watch_chromium.org, timurrrr+watch_chromium.org, bruening+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src@master
Project:
chromium
Visibility:
Public.

Description

Add mojo_system_unittest back to valgrind bots, which was removed by accident in https://codereview.chromium.org/681493003 R=jamesr@chromium.org NOTRY=true Committed: https://crrev.com/7f8433e2564cad19fff0a164e5cc731f46a3b81f Cr-Commit-Position: refs/heads/master@{#301468}

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M tools/valgrind/chrome_tests.py View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
oshima
6 years, 1 month ago (2014-10-27 21:04:02 UTC) #4
jamesr
Thanks, lgtm
6 years, 1 month ago (2014-10-27 21:06:19 UTC) #5
oshima
derek, I still need your approval to land. thanks.
6 years, 1 month ago (2014-10-27 22:18:33 UTC) #6
Alexander Potapenko
On 2014/10/27 22:18:33, oshima wrote: > derek, I still need your approval to land. thanks. ...
6 years, 1 month ago (2014-10-27 22:30:50 UTC) #7
oshima
On 2014/10/27 22:30:50, Alexander Potapenko wrote: > On 2014/10/27 22:18:33, oshima wrote: > > derek, ...
6 years, 1 month ago (2014-10-27 22:40:03 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/683493004/40001
6 years, 1 month ago (2014-10-27 22:41:43 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:40001)
6 years, 1 month ago (2014-10-27 22:46:33 UTC) #11
commit-bot: I haz the power
6 years, 1 month ago (2014-10-27 22:47:13 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7f8433e2564cad19fff0a164e5cc731f46a3b81f
Cr-Commit-Position: refs/heads/master@{#301468}

Powered by Google App Engine
This is Rietveld 408576698