Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(265)

Issue 681493003: Remove tests from tools/valgrind/chrome_tests.py that are going away (Closed)

Created:
6 years, 2 months ago by jamesr
Modified:
6 years, 2 months ago
Reviewers:
Derek Bruening
CC:
chromium-reviews, glider+watch_chromium.org, timurrrr+watch_chromium.org, bruening+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Remove tests from tools/valgrind/chrome_tests.py that are going away The code for these test binaries is being removed from the chromium repo (see https://groups.google.com/a/chromium.org/forum/#!topic/chromium-dev/nAwEbgCrUio) so we don't need to have the mappings in the tools/valgrind/chrome_tests.py script in the chromium repository. R=bruening@chromium.org Committed: https://crrev.com/070a7168be40e0c279b14796a961e0b741dc4331 Cr-Commit-Position: refs/heads/master@{#301245}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -18 lines) Patch
M tools/valgrind/chrome_tests.py View 3 chunks +0 lines, -18 lines 0 comments Download

Messages

Total messages: 14 (5 generated)
jamesr
6 years, 2 months ago (2014-10-24 21:51:06 UTC) #1
Derek Bruening
LGTM
6 years, 2 months ago (2014-10-24 21:55:10 UTC) #2
jamesr
On 2014/10/24 21:55:10, Derek Bruening wrote: > LGTM OK, think I need to land the ...
6 years, 2 months ago (2014-10-24 21:56:18 UTC) #5
jamesr
On 2014/10/24 21:56:18, jamesr wrote: > On 2014/10/24 21:55:10, Derek Bruening wrote: > > LGTM ...
6 years, 2 months ago (2014-10-24 23:24:04 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/681493003/1
6 years, 2 months ago (2014-10-24 23:25:54 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_dbg_recipe on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_arm64_dbg_recipe/builds/16209) android_chromium_gn_compile_dbg on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromium_gn_compile_dbg/builds/11192) android_chromium_gn_compile_rel ...
6 years, 2 months ago (2014-10-24 23:35:49 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/681493003/1
6 years, 2 months ago (2014-10-24 23:46:14 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 2 months ago (2014-10-25 00:34:08 UTC) #13
commit-bot: I haz the power
6 years, 2 months ago (2014-10-25 00:34:44 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/070a7168be40e0c279b14796a961e0b741dc4331
Cr-Commit-Position: refs/heads/master@{#301245}

Powered by Google App Engine
This is Rietveld 408576698