Issue 683133006: Remove coverage from grpaint

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 683133006: Remove coverage from grpaint (Closed)

Created:
6 years, 1 month ago by joshua.litt

Modified:
6 years, 1 month ago

Reviewers:
joshualitt, bsalomon

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia.git@master

Project:
skia

Visibility:
Public.

More Reviews

Description

Remove coverage from grpaint BUG=skia: Committed: https://skia.googlesource.com/skia/+/4052a8e4f2b54fb999163edfeec64b0f2c8b9c47

Patch Set 4 : cleanup #

Created: 6 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -15 lines)			Patch
M	include/gpu/GrPaint.h	View		5 chunks	+0 lines, -13 lines	0 comments	Download
M	src/gpu/GrDrawState.cpp	View	1 2 3	1 chunk	+1 line, -1 line	0 comments	Download
M	src/gpu/GrPaint.cpp	View	1 2 3	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 6 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

bsalomon

https://codereview.chromium.org/683133006/diff/40001/src/gpu/GrPaint.cpp File src/gpu/GrPaint.cpp (right): https://codereview.chromium.org/683133006/diff/40001/src/gpu/GrPaint.cpp#newcode56 src/gpu/GrPaint.cpp:56: inout.fColor = GrColorPackRGBA(0xFF, 0xFF, 0xFF, 0xFF); 0xffffffff? otherwise lgtm

6 years, 1 month ago (2014-11-11 18:37:02 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/683133006/60001

6 years, 1 month ago (2014-11-11 21:38:50 UTC) #5

commit-bot: I haz the power

6 years, 1 month ago (2014-11-11 21:46:35 UTC) #6

Message was sent while issue was closed.

Committed patchset #4 (id:60001) as
https://skia.googlesource.com/skia/+/4052a8e4f2b54fb999163edfeec64b0f2c8b9c47

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Issue 683133006: Remove coverage from grpaint (Closed)

Description

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : cleanup #

Messages