Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(382)

Unified Diff: tools/clang/plugins/tests/virtual_specifiers.txt

Issue 683113005: Update from chromium https://crrev.com/302282 (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/clang/plugins/tests/virtual_specifiers.txt
diff --git a/tools/clang/plugins/tests/virtual_specifiers.txt b/tools/clang/plugins/tests/virtual_specifiers.txt
index 1f2e4755a09d40d59c82c953ce70dc0aa7c206a3..a51236c674e16905944a427d015c3191d3aef0c3 100644
--- a/tools/clang/plugins/tests/virtual_specifiers.txt
+++ b/tools/clang/plugins/tests/virtual_specifiers.txt
@@ -48,11 +48,22 @@ virtual_specifiers.cpp:62:12: warning: [chromium-style] 'override' is redundant;
virtual_specifiers.cpp:10:18: note: expanded from macro 'OVERRIDE'
#define OVERRIDE override
^
-virtual_specifiers.cpp:85:20: warning: [chromium-style] Overriding method must be marked with 'override' or 'final'.
+virtual_specifiers.cpp:67:19: warning: [chromium-style] Overriding method must be marked with 'override' or 'final'.
+ virtual void F() = 0;
+ ^
+ override
+virtual_specifiers.cpp:71:11: warning: [chromium-style] Overriding method must be marked with 'override' or 'final'.
+ void F() = 0;
+ ^
+ override
+virtual_specifiers.cpp:79:3: warning: [chromium-style] 'virtual' is redundant; 'override' implies 'virtual'.
+ virtual void F() override = 0;
+ ^~~~~~~~
+virtual_specifiers.cpp:102:20: warning: [chromium-style] Overriding method must be marked with 'override' or 'final'.
virtual ~MyTest();
^
override
-virtual_specifiers.cpp:86:3: warning: [chromium-style] 'virtual' is redundant; 'override' implies 'virtual'.
+virtual_specifiers.cpp:103:3: warning: [chromium-style] 'virtual' is redundant; 'override' implies 'virtual'.
virtual void SetUp() override;
^~~~~~~~
-14 warnings generated.
+17 warnings generated.
« no previous file with comments | « tools/clang/plugins/tests/virtual_specifiers.cpp ('k') | tools/generate_library_loader/generate_library_loader.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698