tools/clang/plugins/tests/virtual_specifiers.txt - Issue 683113005: Update from chromium https://crrev.com/302282

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: tools/clang/plugins/tests/virtual_specifiers.txt

Issue 683113005: Update from chromium https://crrev.com/302282 (Closed) Base URL: git@github.com:domokit/mojo.git@master

Patch Set: Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 virtual_specifiers.cpp:36:21: warning: [chromium-style] Overriding method must b e marked with 'override' or 'final'.	1 virtual_specifiers.cpp:36:21: warning: [chromium-style] Overriding method must b e marked with 'override' or 'final'.

2 ~MissingOverride() {}	2 ~MissingOverride() {}

3 ^	3 ^

4 override	4 override

5 virtual_specifiers.cpp:37:11: warning: [chromium-style] Overriding method must b e marked with 'override' or 'final'.	5 virtual_specifiers.cpp:37:11: warning: [chromium-style] Overriding method must b e marked with 'override' or 'final'.

6 void F() {}	6 void F() {}

7 ^	7 ^

8 override	8 override

9 virtual_specifiers.cpp:43:3: warning: [chromium-style] 'virtual' is redundant; ' override' implies 'virtual'.	9 virtual_specifiers.cpp:43:3: warning: [chromium-style] 'virtual' is redundant; ' override' implies 'virtual'.

10 virtual ~VirtualAndOverride() OVERRIDE {}	10 virtual ~VirtualAndOverride() OVERRIDE {}

(...skipping 30 matching lines...) Expand all Loading...
41 ^~~~~~~~~	41 ^~~~~~~~~

42 virtual_specifiers.cpp:10:18: note: expanded from macro 'OVERRIDE'	42 virtual_specifiers.cpp:10:18: note: expanded from macro 'OVERRIDE'

43 #define OVERRIDE override	43 #define OVERRIDE override

44 ^	44 ^

45 virtual_specifiers.cpp:62:12: warning: [chromium-style] 'override' is redundant; 'final' implies 'override'.	45 virtual_specifiers.cpp:62:12: warning: [chromium-style] 'override' is redundant; 'final' implies 'override'.

46 void F() OVERRIDE FINAL {}	46 void F() OVERRIDE FINAL {}

47 ^~~~~~~~~	47 ^~~~~~~~~

48 virtual_specifiers.cpp:10:18: note: expanded from macro 'OVERRIDE'	48 virtual_specifiers.cpp:10:18: note: expanded from macro 'OVERRIDE'

49 #define OVERRIDE override	49 #define OVERRIDE override

50 ^	50 ^

51 virtual_specifiers.cpp:85:20: warning: [chromium-style] Overriding method must b e marked with 'override' or 'final'.	51 virtual_specifiers.cpp:67:19: warning: [chromium-style] Overriding method must b e marked with 'override' or 'final'.

	52 virtual void F() = 0;

	53 ^

	54 override

	55 virtual_specifiers.cpp:71:11: warning: [chromium-style] Overriding method must b e marked with 'override' or 'final'.

	56 void F() = 0;

	57 ^

	58 override

	59 virtual_specifiers.cpp:79:3: warning: [chromium-style] 'virtual' is redundant; ' override' implies 'virtual'.

	60 virtual void F() override = 0;

	61 ^~~~~~~~

	62 virtual_specifiers.cpp:102:20: warning: [chromium-style] Overriding method must be marked with 'override' or 'final'.

52 virtual ~MyTest();	63 virtual ~MyTest();

53 ^	64 ^

54 override	65 override

55 virtual_specifiers.cpp:86:3: warning: [chromium-style] 'virtual' is redundant; ' override' implies 'virtual'.	66 virtual_specifiers.cpp:103:3: warning: [chromium-style] 'virtual' is redundant; 'override' implies 'virtual'.

56 virtual void SetUp() override;	67 virtual void SetUp() override;

57 ^~~~~~~~	68 ^~~~~~~~

58 14 warnings generated.	69 17 warnings generated.

OLD	NEW

« no previous file with comments | « tools/clang/plugins/tests/virtual_specifiers.cpp ('k') | tools/generate_library_loader/generate_library_loader.py » ('j') | no next file with comments »