Rename websocket_handshake_handler.* to websocket_handshake_challenge.*

Rename websocket_handshake_handler.* to websocket_handshake_challenge.*

Simplify the calling convention of ComputeSecWebSocketAccept to just return a string, and add a test for it.

BUG=
TEST=net_unittests

Committed: https://crrev.com/11bdcd08b9aa8413b2096f542cf81d4251114832
Cr-Commit-Position: refs/heads/master@{#304996}

[Adam Rice, 2014-11-11 16:29:19]

ricea@chromium.org changed reviewers:
+ tyoshino@chromium.org

[Adam Rice, 2014-11-11 16:29:21]

I am considering changing the signature of ComputeSecWebSocketAccept from void
ComputeSecWebSocketAccept(string,string*) to
string ComputeSecWebSocketAccept(string)

Let me know what you think.

[tyoshino (SeeGerritForStatus), 2014-11-12 05:04:26]

lgtm

https://codereview.chromium.org/683033003/diff/1/net/websockets/websocket_han...
File net/websockets/websocket_handshake_challenge_test.cc (right):

https://codereview.chromium.org/683033003/diff/1/net/websockets/websocket_han...
net/websockets/websocket_handshake_challenge_test.cc:13: // Test the challenge
from RFC6455.
let's add "example"

from RFC6455 example

[tyoshino (SeeGerritForStatus), 2014-11-12 05:04:42]

On 2014/11/11 16:29:21, Adam Rice wrote:
> I am considering changing the signature of ComputeSecWebSocketAccept from void
> ComputeSecWebSocketAccept(string,string*) to
> string ComputeSecWebSocketAccept(string)
> 
> Let me know what you think.

Sounds fine.

[tyoshino (SeeGerritForStatus), 2014-11-12 05:05:33]

https://codereview.chromium.org/683033003/diff/1/net/websockets/websocket_han...
File net/websockets/websocket_handshake_challenge_test.cc (right):

https://codereview.chromium.org/683033003/diff/1/net/websockets/websocket_han...
net/websockets/websocket_handshake_challenge_test.cc:4: 
#include <string>

[Adam Rice, 2014-11-12 11:24:17]

PTAL

https://codereview.chromium.org/683033003/diff/1/net/websockets/websocket_han...
File net/websockets/websocket_handshake_challenge_test.cc (right):

https://codereview.chromium.org/683033003/diff/1/net/websockets/websocket_han...
net/websockets/websocket_handshake_challenge_test.cc:4: 
On 2014/11/12 05:05:32, tyoshino wrote:
> #include <string>

Done.

https://codereview.chromium.org/683033003/diff/1/net/websockets/websocket_han...
net/websockets/websocket_handshake_challenge_test.cc:13: // Test the challenge
from RFC6455.
On 2014/11/12 05:04:26, tyoshino wrote:
> let's add "example"
> 
> from RFC6455 example

Done.

[tyoshino (SeeGerritForStatus), 2014-11-12 11:50:45]

lgtm

[Adam Rice, 2014-11-12 12:05:55]

ricea@chromium.org changed reviewers:
+ wtc@chromium.org

[Adam Rice, 2014-11-12 12:05:56]

+wtc, does this satisfy your requirements?

[wtc, 2014-11-12 20:11:56]

Patch set 2 LGTM.

It seems sub-optimal to devote a header file to only one function. But this is
fine by me.

Note that I am no longer an owner of net.

https://codereview.chromium.org/683033003/diff/20001/net/websockets/websocket...
File net/websockets/websocket_handshake_challenge.cc (right):

https://codereview.chromium.org/683033003/diff/20001/net/websockets/websocket...
net/websockets/websocket_handshake_challenge.cc:8: #include "base/logging.h"

Nit: "base/logging.h" can be omitted.

https://codereview.chromium.org/683033003/diff/20001/net/websockets/websocket...
File net/websockets/websocket_handshake_challenge.h (right):

https://codereview.chromium.org/683033003/diff/20001/net/websockets/websocket...
net/websockets/websocket_handshake_challenge.h:15: NET_EXPORT_PRIVATE
std::string ComputeSecWebSocketAccept(

I assume the response to the challenge is called an "accept" in the WebSocket
specification?

[Adam Rice, 2014-11-13 15:24:38]

https://codereview.chromium.org/683033003/diff/20001/net/websockets/websocket...
File net/websockets/websocket_handshake_challenge.cc (right):

https://codereview.chromium.org/683033003/diff/20001/net/websockets/websocket...
net/websockets/websocket_handshake_challenge.cc:8: #include "base/logging.h"
On 2014/11/12 20:11:55, wtc wrote:
> 
> Nit: "base/logging.h" can be omitted.

Thanks. Done.

https://codereview.chromium.org/683033003/diff/20001/net/websockets/websocket...
File net/websockets/websocket_handshake_challenge.h (right):

https://codereview.chromium.org/683033003/diff/20001/net/websockets/websocket...
net/websockets/websocket_handshake_challenge.h:15: NET_EXPORT_PRIVATE
std::string ComputeSecWebSocketAccept(
On 2014/11/12 20:11:55, wtc wrote:
> 
> I assume the response to the challenge is called an "accept" in the WebSocket
> specification?

Indeed. The header name is Sec-WebSocket-Accept. I have clarified the comment.

[Adam Rice, 2014-11-13 15:27:53]

ricea@chromium.org changed reviewers:
+ eroman@chromium.org

[Adam Rice, 2014-11-13 15:27:53]

+eroman for net/ OWNERS.

[eroman, 2014-11-19 00:00:28]

LGTM

(sorry for slowness, I thought wtc was a net/ owner!)

https://codereview.chromium.org/683033003/diff/40001/net/websockets/websocket...
File net/websockets/websocket_handshake_challenge.h (right):

https://codereview.chromium.org/683033003/diff/40001/net/websockets/websocket...
net/websockets/websocket_handshake_challenge.h:1: // Copyright (c) 2012 The
Chromium Authors. All rights reserved.
2014

[Adam Rice, 2014-11-20 08:33:00]

The CQ bit was checked by ricea@chromium.org

[commit-bot: I haz the power, 2014-11-20 08:33:33]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/683033003/60001

[commit-bot: I haz the power, 2014-11-20 09:57:18]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2014-11-20 09:58:10]

Patchset 4 (id:??) landed as
https://crrev.com/11bdcd08b9aa8413b2096f542cf81d4251114832
Cr-Commit-Position: refs/heads/master@{#304996}