net/websockets/websocket_handshake_challenge.h - Issue 683033003: Rename websocket_handshake_handler.* to websocket_handshake_challenge.*

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: net/websockets/websocket_handshake_challenge.h

Issue 683033003: Rename websocket_handshake_handler.* to websocket_handshake_challenge.* (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Change calling convention of ComputeSecWebSocketAccept Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « net/websockets/websocket_basic_handshake_stream.cc ('k') | net/websockets/websocket_handshake_challenge.cc » ('j') | net/websockets/websocket_handshake_challenge.cc » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #ifndef NET_WEBSOCKETS_WEBSOCKET_HANDSHAKE_CHALLENGE_H_

	6 #define NET_WEBSOCKETS_WEBSOCKET_HANDSHAKE_CHALLENGE_H_

	7

	8 #include <string>

	9

	10 #include "net/base/net_export.h"

	11

	12 namespace net {

	13

	14 // Given a WebSocket handshake challenge, compute the correct response.

	15 NET_EXPORT_PRIVATE std::string ComputeSecWebSocketAccept(
	wtc 2014/11/12 20:11:55 I assume the response to the challenge is called a I assume the response to the challenge is called an "accept" in the WebSocket specification? Adam Rice 2014/11/13 15:24:38 Indeed. The header name is Sec-WebSocket-Accept. I Show quoted text On 2014/11/12 20:11:55, wtc wrote: > > I assume the response to the challenge is called an "accept" in the WebSocket > specification? Indeed. The header name is Sec-WebSocket-Accept. I have clarified the comment.
	16 const std::string& key);

	17

	18 } // namespace net

	19

	20 #endif // NET_WEBSOCKETS_WEBSOCKET_HANDSHAKE_CHALLENGE_H_

OLD	NEW