Issue 682893002: Parse comments according to parsing.md

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 682893002: Parse comments according to parsing.md (Closed)

Created:
6 years, 1 month ago by abarth-chromium

Modified:
6 years, 1 month ago

Reviewers:
eseidel

CC:
mojo-reviews_chromium.org, ojan, esprehn

Base URL:
git@github.com:domokit/mojo.git@master

Project:
mojo

Visibility:
Public.

Parse comments according to parsing.md Now we don't even generate comment tokens. The new tokenizer for comments is much easier. R=eseidel@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/31d6a79865182b02bf836c75ced4af6ca6bfbd0a

Created: 6 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+49 lines, -177 lines)			Patch
M	sky/engine/core/html/parser/AtomicHTMLToken.h	View	4 chunks	+1 line, -9 lines	0 comments	Download
M	sky/engine/core/html/parser/CompactHTMLToken.cpp	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	sky/engine/core/html/parser/HTMLToken.h	View	3 chunks	+1 line, -24 lines	0 comments	Download
M	sky/engine/core/html/parser/HTMLTokenizer.h	View	2 chunks	+5 lines, -12 lines	0 comments	Download
M	sky/engine/core/html/parser/HTMLTokenizer.cpp	View	4 chunks	+30 lines, -128 lines	0 comments	Download
M	sky/engine/core/html/parser/HTMLTreeBuilder.cpp	View	1 chunk	+1 line, -2 lines	0 comments	Download
A +	sky/tests/parser/comments.html	View	1 chunk	+10 lines, -1 line	0 comments	Download
A	sky/tests/parser/comments-expected.txt	View	1 chunk	+1 line, -0 lines	0 comments	Download

Total messages: 6 (2 generated)

commit-bot: I haz the power

Commit queue rejected this change because it did not recognize the base URL. Please commit ...

6 years, 1 month ago (2014-10-27 23:54:26 UTC) #5

abarth-chromium

6 years, 1 month ago (2014-10-28 00:04:55 UTC) #6

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
31d6a79865182b02bf836c75ced4af6ca6bfbd0a (presubmit successful).