sky/engine/core/html/parser/HTMLTreeBuilder.cpp - Issue 682893002: Parse comments according to parsing.md

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sky/engine/core/html/parser/HTMLTreeBuilder.cpp

Issue 682893002: Parse comments according to parsing.md (Closed) Base URL: git@github.com:domokit/mojo.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: sky/engine/core/html/parser/HTMLTreeBuilder.cpp

diff --git a/sky/engine/core/html/parser/HTMLTreeBuilder.cpp b/sky/engine/core/html/parser/HTMLTreeBuilder.cpp

index 89fc3a85492e3d31c01bc31f651bc5ecc318019f..710a99df3c15da05a024bd78d5d821ae84ef7858 100644

--- a/sky/engine/core/html/parser/HTMLTreeBuilder.cpp

+++ b/sky/engine/core/html/parser/HTMLTreeBuilder.cpp

@@ -128,8 +128,7 @@ void HTMLTreeBuilder::constructTree(AtomicHTMLToken* token)

} else if (type == HTMLToken::EndOfFile) {

processEndOfFile(token);

} else {

- // We ignore Comments.

- ASSERT(type == HTMLToken::Comment);

+ ASSERT_NOT_REACHED();

}

m_tree.executeQueuedTasks();

« no previous file with comments | « sky/engine/core/html/parser/HTMLTokenizer.cpp ('k') | sky/tests/parser/comments.html » ('j') | no next file with comments »