Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(212)

Issue 682863004: print preview: Fix visual tab order for "Print"/"Cancel" buttons. (Closed)

Created:
6 years, 1 month ago by Dan Beam
Modified:
6 years, 1 month ago
CC:
chromium-reviews, arv+watch_chromium.org, oshima+watch_chromium.org, Evan Stade
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

print preview: Fix visual tab order for "Print"/"Cancel" buttons. Also unforks some code and does a TODO(estade). R=alekseys@chromium.org TBR=vitalybuka@chromium.org BUG=383955 Committed: https://crrev.com/be340fc4f1e630896b571128b4a593d1e8df6eca Cr-Commit-Position: refs/heads/master@{#302033}

Patch Set 1 #

Patch Set 2 : nits #

Patch Set 3 : nits #

Unified diffs Side-by-side diffs Delta from patch set Stats (+54 lines, -32 lines) Patch
M chrome/browser/resources/print_preview/print_header.css View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/resources/print_preview/print_header.html View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/print_preview/print_header.js View 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/browser/resources/print_preview/print_preview.css View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/browser/resources/print_preview/print_preview.html View 1 chunk +1 line, -0 lines 0 comments Download
A ui/webui/resources/js/cr/ui/node_utils.js View 1 2 1 chunk +33 lines, -0 lines 0 comments Download
M ui/webui/resources/js/cr/ui/page_manager/page.js View 2 chunks +6 lines, -18 lines 0 comments Download
M ui/webui/resources/js/cr/ui/page_manager/page_manager.js View 1 chunk +1 line, -6 lines 0 comments Download
M ui/webui/resources/webui_resources.grd View 3 chunks +6 lines, -3 lines 0 comments Download

Messages

Total messages: 13 (4 generated)
Dan Beam
6 years, 1 month ago (2014-10-28 04:37:06 UTC) #1
Dan Beam
ping
6 years, 1 month ago (2014-10-29 21:21:01 UTC) #2
Aleksey Shlyapnikov
lgtm
6 years, 1 month ago (2014-10-30 03:25:09 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/682863004/30001
6 years, 1 month ago (2014-10-30 03:35:58 UTC) #5
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
6 years, 1 month ago (2014-10-30 03:36:00 UTC) #7
Dan Beam
TBR=vitalybuka@ for OWNERS (he tends to defer to alekseys@ often anyways)
6 years, 1 month ago (2014-10-30 03:36:51 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/682863004/30001
6 years, 1 month ago (2014-10-30 03:37:57 UTC) #11
commit-bot: I haz the power
Committed patchset #3 (id:30001)
6 years, 1 month ago (2014-10-30 04:26:35 UTC) #12
commit-bot: I haz the power
6 years, 1 month ago (2014-10-30 04:27:16 UTC) #13
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/be340fc4f1e630896b571128b4a593d1e8df6eca
Cr-Commit-Position: refs/heads/master@{#302033}

Powered by Google App Engine
This is Rietveld 408576698