Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(289)

Unified Diff: ui/webui/resources/js/cr/ui/page_manager/page.js

Issue 682863004: print preview: Fix visual tab order for "Print"/"Cancel" buttons. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: nits Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ui/webui/resources/js/cr/ui/node_utils.js ('k') | ui/webui/resources/js/cr/ui/page_manager/page_manager.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/webui/resources/js/cr/ui/page_manager/page.js
diff --git a/ui/webui/resources/js/cr/ui/page_manager/page.js b/ui/webui/resources/js/cr/ui/page_manager/page.js
index 5686665e76bfc742113b3e882cdba2be071c1738..c80073567d5ebd7e5db02ae14d996d9586497425 100644
--- a/ui/webui/resources/js/cr/ui/page_manager/page.js
+++ b/ui/webui/resources/js/cr/ui/page_manager/page.js
@@ -2,6 +2,8 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
+<include src="../node_utils.js">
+
cr.define('cr.ui.pageManager', function() {
var PageManager = cr.ui.pageManager.PageManager;
@@ -93,27 +95,13 @@ cr.define('cr.ui.pageManager', function() {
},
/**
- * Reverses the child elements of this overlay's button strip if it hasn't
- * already been reversed. This is necessary because WebKit does not alter
- * the tab order for elements that are visually reversed using
- * flex-direction: reverse, and the button order is reversed for views.
- * See http://webk.it/62664 for more information.
+ * Reverse any buttons strips in this page (only applies to overlays).
+ * @see cr.ui.reverseButtonStrips for an explanation of why this is
+ * necessary and when it's done.
*/
reverseButtonStrip: function() {
assert(this.isOverlay);
- var buttonStrips =
- this.pageDiv.querySelectorAll('.button-strip:not([reversed])');
-
- // Reverse all button-strips in the overlay.
- for (var j = 0; j < buttonStrips.length; j++) {
- var buttonStrip = buttonStrips[j];
-
- var childNodes = buttonStrip.childNodes;
- for (var i = childNodes.length - 1; i >= 0; i--)
- buttonStrip.appendChild(childNodes[i]);
-
- buttonStrip.setAttribute('reversed', '');
- }
+ cr.ui.reverseButtonStrips(this.pageDiv);
},
/**
« no previous file with comments | « ui/webui/resources/js/cr/ui/node_utils.js ('k') | ui/webui/resources/js/cr/ui/page_manager/page_manager.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698